Fix set_max_number_of_lines
causing crash on UIKit
#98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon calling
set_max_number_of_lines
on a Label it crashes an iOS application at runtime.Crash output:
This seems to only happen on iOS. Replacing
let _: () = msg_send![obj, setMaximumNumberOfLines: num];
withlet _: () = msg_send![obj, setNumberOfLines: num];
seems to resolve the issue on iOS and causes a crash on macOS.With this pull commit using the feature flags, the label works as expected on iOS and macOS.