Skip to content

Conversation

fogti
Copy link
Contributor

@fogti fogti commented Jan 26, 2021

Fixes #522.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 57.201% when pulling 61c1ba9 on zserik:fix4pep479 into 8e004f5 on ryanmcgrath:master.

dealing with the Twitter API
"""

from __future__ import generator_stop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if this import is actually needed.

@fogti
Copy link
Contributor Author

fogti commented Jul 16, 2021

@RaitoBezarius could you please review this PR?

@ryanmcgrath could you please merge this PR? (refs: #522 (comment), #522 (comment))

@ryanmcgrath
Copy link
Owner

Ah, I can merge this if one or two people test it and say it's good to go. I assume this'd also need a release bump?

@fogti
Copy link
Contributor Author

fogti commented Jul 16, 2021

I'm not completely sure anymore, but I thought I had tested it.

@ryanmcgrath
Copy link
Owner

Oh, I believe you tested it - it's more that I don't touch this part of the library these days, so want to be sure that:

A) it's got a decent pair of eyes on it (though given issue 522 I suppose we could just yolo it, since the discussion there has been around for some time)

B) we do a version bump so we're not blowing up too many existing setups etc

Let's ping @RaitoBezarius one more time, and then if they're too busy to take a peek (given it's also been some time) we'll go the yolo approach.

@RaitoBezarius
Copy link

RaitoBezarius commented Jul 16, 2021

To be honest, I didn't test it yet, but it looks good, I think the yolo plan is not that much absurd.
I think the __future__ import makes sense for older Python 3 versions, but should work more or less fine on latest ones IMHO.

So all good for me @ryanmcgrath !

@ryanmcgrath ryanmcgrath merged commit e8306c4 into ryanmcgrath:master Jul 16, 2021
@ryanmcgrath
Copy link
Owner

Alright, a 3.9.0 should be on Pypi now.

@fogti fogti deleted the fix4pep479 branch July 16, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For loop in twython search results raises StopIteration
4 participants