-
Notifications
You must be signed in to change notification settings - Fork 396
Fix #522 (needed bc of PEP 479) #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dealing with the Twitter API | ||
""" | ||
|
||
from __future__ import generator_stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if this import
is actually needed.
@RaitoBezarius could you please review this PR? @ryanmcgrath could you please merge this PR? (refs: #522 (comment), #522 (comment)) |
Ah, I can merge this if one or two people test it and say it's good to go. I assume this'd also need a release bump? |
I'm not completely sure anymore, but I thought I had tested it. |
Oh, I believe you tested it - it's more that I don't touch this part of the library these days, so want to be sure that: A) it's got a decent pair of eyes on it (though given issue 522 I suppose we could just yolo it, since the discussion there has been around for some time) B) we do a version bump so we're not blowing up too many existing setups etc Let's ping @RaitoBezarius one more time, and then if they're too busy to take a peek (given it's also been some time) we'll go the yolo approach. |
To be honest, I didn't test it yet, but it looks good, I think the yolo plan is not that much absurd. So all good for me @ryanmcgrath ! |
Alright, a |
Fixes #522.