-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cousine Nerd Font] Adding round borderchars. #1108
Comments
Thank you for raising the Issue. Maybe we should increase Powerlevel compatibility, triggered by discussion with @igniscyan The next comments will show what would be needed. Some links This fits into another current discussion in There are other related issues all over and also some changes
Maybe also consider again |
Powerlevel10k offers a specifically patched font for usage with their prompt system. The patching is done here. The changes consist of these commits
Analyzing the changes
|
We do not patch them in. Some Nerd Fonts fonts have them (if the original font has them), some dont. If the original font has them already in and we do change the 'cell' size (which might happen), then the glyphs do not reach the border anymore or protrude too much out of the 'cell'. Because we just change the 'cell' size globally without rescaling exiting glyphs. |
Your terminal (whichever that is) substitudes it?
? |
On my machine
despite current Cousine installed: |
No, it does not support
|
Yes. So the |
Tilix and charmap are written in a way that they use another font if the asked-for glyph is not in the selected font. |
Note to self: Cousine has negative rhs bearing at Aogonek 😬 I thought there is one corner in the code that I do not need to touch, but ... alas .. that breaks our cell calculations that can not make up their mind if they want to take the advance width or the bounding box width.
|
Fixes: #1108 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Fixes: #1108 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Fixes: #1108 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Fixes: #1108 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Fixes: #1108 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Fixes: #1108 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
Fixes: ryanoasis#1108 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Is your feature request related to a problem? Please describe.
I'm using Cousine Nerd Font for display text and icon for vim terminal also gvim. Today, I worked with some settings with borderchars then I realized that Cousine Nerd Font not support it. I changed to Hack Nerd Font, it can display round borderchars like my expectation.
So I wonder if Cousine Nerd Font can have round borderchars
'─│─│╭╮╯╰'
Additional context
bandicam.2023-02-06.11-39-52-082.mp4
The text was updated successfully, but these errors were encountered: