Add CommitMono font

[tranzystorekk]

Requirements

• I have searched the issues for my request and found nothing related and/or helpful
• I have searched the FAQ for help
• I have searched the Wiki for help

Description

Font webpage: https://commitmono.com/

Font git repository: https://github.com/eigilnikolajsen/commit-mono

Font license: SIL Open Font 1.1

[ghost]

Hi, I patched the font using font-patcher 3.0.2 but I get this weird vertical lines in Linux (Konsole and Xfce Terminal) but not in macOS (Iterm2).

CommitMonoNerdFont.zip

Any idea on how to fix it?

[Finii]

The lines: * Change your system's antialiasing to `monochrome` (recommemded)  * Or, if you feel comfortable editing `font-patcher`, increase the `overlap` to 0.06 or so #780 (comment)

…

________________________________ From: Jorge García ***@***.***> Sent: Thursday, 10 August 2023 23:43 To: ryanoasis/nerd-fonts Cc: Subscribed Subject: Re: [ryanoasis/nerd-fonts] Add CommitMono font (Issue #1334) Hi, I patched the font using font-patcher 3.0.2 but I got this weird vertical lines in Linux (Konsole and Xfce Terminal) but not in macOS (Iterm2). CommitMonoNerdFont.zip Any Idea How to fix it? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ghost]

Thanks, Finii. I couldn't find how to set antialiasing to monochrome in KDE. Searching for antialiasing issues in KDE and Konsole found that changing sub-pixel rendering from RGB to VRGB removes the lines.

[riiyaa24]

Hello, I would like to work on this issue. Can you assign me this PR?

[tranzystorekk]

@riiyaa24 there doesn't seem to be any PR for this yet, you can start coding and most probably no one will swipe it away from you 😄

[Finii]

We do not do assignments here, usually.

Otoh, your Issue report is good and it will be very easy for me to add the font from the details given in it. Most of the process is automated. As I wrote in some other add-new-font issue, the new release is a bit overdue. I wanted to fix some bugs first and then (*) update and add fonts and trigger the release. The time consuming part is the bugs, and my time is a bit scarce lately :-(

(*) If we first update and add fonts they might be outdated when the actual release happens after fixing the bugs. So that is the reason for that ordering.

[uncenter]

Any update on this? Interested in helping move this along.

[Finii]

Thank you @uncenter, but adding a font is not hard :-)

We need to figure out which of the 100th of suggested new fonts we really want to add; and commit to maintain them for the next 10+ years. So that is not so easy, judging if there is an audience for a specific font.

Which is the case with this font I guess (interest from more than one person I mean).

I will try to come up with a list of all fonts that were suggested (i.e. expand #1095 (comment)) and then ... I really hate that I always have to discuss just with myself or persons that want that one font, instead of people that have no specific interests in one font ;-) If you know what I mean.

[uncenter]

Yeah I have my own patched font but I thought I'd see what I could do here. I see what you mean about the types of fonts / size of audiences of fonts you want to add - I misunderstood your previous comment and I didn't think that was an issue, was just trying to see what the blocker was. Thank you for the clarification!

[Finii]

Closing because transferred to #1095

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.