Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fork us on GitHub" Label on Homepage Covering One of Navbar Option (in Small Screen) #1366

Closed
3 tasks done
iamRabia-N opened this issue Oct 2, 2023 · 12 comments
Closed
3 tasks done

Comments

@iamRabia-N
Copy link

iamRabia-N commented Oct 2, 2023

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:
"Fork us on GitHub" label is covering one of homepage navbar option in small screen.

Expected behavior:
Label correctly aligned on the right side.

★ Screenshots (Optional)

Current Design

img (6)

Expected Updated Design

img (7)

Kindly assign me this issue.

@akhileshallewar880
Copy link

Hi, I'm interested in working on this issue. Could you please assign it to me....

@Finii Finii added the confirmed label Oct 4, 2023
@AnshikaGupta6112
Copy link

Hi, I'd like to take on this task. Can you please assign it to me?

@Finii
Copy link
Collaborator

Finii commented Oct 4, 2023

Thank you for reporting the issue!

I believe instead of shrinking the label it would be better to make it click-through? It is quite unreadable with the very small font.

There also seems to be something broken with the tabs rescaling. If the window gets smaller and smaller, first the tabs overflow in a second line, and then the short words are used instead (and then the font size is decreased):

image

image

image

image

image

@Finii
Copy link
Collaborator

Finii commented Oct 4, 2023

Ugg, I have no experience here, now three people want to be assigned? What shall I do :-}

But then, this is at least two different problems... 🤔

@Finii
Copy link
Collaborator

Finii commented Oct 4, 2023

Hmm, the tab code is here: https://github.com/ryanoasis/nerd-fonts/blob/gh-pages/_includes/topnav.html
That seems to be a general Jekyll problem?

@ghost
Copy link

ghost commented Oct 6, 2023

hey @Finii can you please assign this task to me? I can do this for you!
or Is this issue already done?

@Finii
Copy link
Collaborator

Finii commented Oct 6, 2023

@APURVA-MOGAL

See my answer above

I have no experience [with Hacktoberfest], now three people want to be assigned? What shall I do :-}

Which sub-topic do you want to do? Maybe we can split this in two (if that is reasonable)

  • Fork-me covers Tab
  • Tab line becomes two lines with some widths

@Viswaraje
Copy link

Hello @Finii ,I would like to work on this issue if available.

Finii pushed a commit to VitthalGund/nerd-fonts that referenced this issue Oct 9, 2023
Inside the div container github icon is added with link to master branch

Fixes: ryanoasis#1366
Fixes: ryanoasis#1372
@Finii
Copy link
Collaborator

Finii commented Oct 9, 2023

This will be closed by #1373 ; unfortunately I was not able to set the assigment here.

But I will transfer the second half of this discussion to a new issue.

@Finii
Copy link
Collaborator

Finii commented Oct 9, 2023

New Issue is

Thanks for your interest and help!

@Finii Finii added Ready ⛱ Ready to merge but waiting to be merged near a release and removed Ready ⛱ Ready to merge but waiting to be merged near a release labels Oct 9, 2023
@Finii
Copy link
Collaborator

Finii commented Oct 9, 2023

Solved via #1373

@Finii Finii closed this as completed Oct 9, 2023
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants