Skip to content

Conversation

titoBouzout
Copy link
Contributor

@titoBouzout titoBouzout commented Apr 11, 2025

Update minor types for Solid 1.10?.x

  • adds "false" to spellcheck
  • adds details.name attribute
  • boolean attribute as string should be empty as in attr="" instead of attr="true" (we wrongly defaulted to be ="true" instead of being just empty)
  • add several event handlers
  • add some new aria attributes
  • add node script to sync jsx-h.d.ts and jsx.d.ts with instructions on readme about how to update types

So from now on, to update JSX types:

  1. we edit jsx-h.d.ts (the source of truth)
  2. run node jsx-update.mjs in packages/dom-expressions/src/ which will write a new jsx.d.ts with the irrelevant types stripped.

The script to transform the d.ts file is not pretty (is not an AST transformation) but its simple enough and works for me.


Note: The deprecation notices about using camelCase event handlers and using lower case attributes are there, but dom-expression is not yet capable to provide that behaviour. I'm updating the types first, then dom-expressions to have a reference of the wanted behaviour.

titoBouzout and others added 30 commits February 21, 2025 10:34
…so we dont have to check why is not there, we will know it has been deprecated)
…e"`. The string `"false"` should be a type error
…attributes, add `undefined` to possible values
@titoBouzout titoBouzout marked this pull request as ready for review April 26, 2025 01:40
@ryansolid ryansolid merged commit 5b7ad31 into ryansolid:minor Apr 29, 2025
2 checks passed
@ryansolid
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants