-
Notifications
You must be signed in to change notification settings - Fork 144
minor: update JSX types #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so we dont have to check why is not there, we will know it has been deprecated)
…e"`. The string `"false"` should be a type error
…attributes, add `undefined` to possible values
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
minor
types for Solid 1.10?.x"false"
tospellcheck
details.name
attributeattr=""
instead ofattr="true"
(we wrongly defaulted to be ="true" instead of being just empty)jsx-h.d.ts
andjsx.d.ts
with instructions on readme about how to update typesSo from now on, to update JSX types:
jsx-h.d.ts
(the source of truth)node jsx-update.mjs
inpackages/dom-expressions/src/
which will write a newjsx.d.ts
with the irrelevant types stripped.The script to transform the
d.ts
file is not pretty (is not an AST transformation) but its simple enough and works for me.Note: The deprecation notices about using camelCase event handlers and using lower case attributes are there, but
dom-expression
is not yet capable to provide that behaviour. I'm updating the types first, thendom-expressions
to have a reference of the wanted behaviour.