Curl Logging interceptor #141

doyaaaaaken · 2019-07-20T05:37:44Z

Implements #139

I don't know if this PR is correct direction. So, feel free to decline this PR.

doyaaaaaken · 2019-07-20T05:39:54Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+ */
+internal fun Request.buildCurlCommand(): String {
+    var compressed = false
+    //TODO: test


I write test method sample in RequestExtTest.kt.
But not yet write test in many case.
(I write test only about simple GET request case)

After I confirm whether this PR's direction is correct, I'll write test code.

You are on a right way!
Several improvements and this changes will be accepted.

DeviantBadge · 2019-07-20T21:55:03Z

README.md

@@ -345,14 +345,15 @@ val forkedClient = defaultHttpClient.fork {
    A Request Logging Interceptor. 

    Parameters:
-    1.  `log: (String) -> Unit = ::println`:  function as a parameter to consume the log message. It defaults to `println`. Logs Request body when present.
+    1.  `outputCurlCommand: Boolean = false`:  if it's true, output curl command on log message.
+    2.  `log: (String) -> Unit = ::println`:  function as a parameter to consume the log message. It defaults to `println`. Logs Request body when present.


It is better to change parameters order:

log: (String) -> Unit = ::println

outputCurlCommand: Boolean = false
First, because we do not break code of existing kohttp users (they will have compilation error with new library version)
Second, because 'log' parameter represents main logic of LoggingInterceptor and 'outputCurlCommand' is additional parameter

Because, log argument is function, this argument order cannot break code.
Below code is working correctly.

val client = defaultHttpClient.fork { interceptors { ///////old version code (outputCurlCommand argument does not exist)////// //no argument +LoggingInterceptor() //only log argument: +LoggingInterceptor { log -> println(log) } ///////new version code (outputCurlCommand argument exists)////// //only outputCurlCommand +LoggingInterceptor(true) //outputCurlCommand and log arguments: +LoggingInterceptor(true) { log -> println(log) } } }

I think log is function and need two or more line's code, so this order is better.
What do you think about it?

You are definitely right, I was wrong.

DeviantBadge · 2019-07-20T21:56:56Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+ */
+internal fun Request.buildCurlCommand(): String {
+    var compressed = false
+    //TODO: test


You are on a right way!
Several improvements and this changes will be accepted.

DeviantBadge · 2019-07-20T22:12:28Z

src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt

-class LoggingInterceptor(private val log: (String) -> Unit = ::println) : Interceptor {
+class LoggingInterceptor(
+        private val outputCurlCommand: Boolean = false,
+        private val log: (String) -> Unit = ::println


Also one more time - change order of parameters

DeviantBadge · 2019-07-20T22:14:18Z

src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt

+                val command = request.buildCurlCommand()
+                log("╭--- cURL command -------------------------------")
+                log(command)
+                log("╰--- (copy and paste the above line to a terminal)")


I think it is better to put it before kotlin chain.proceed(request) because we logging here only request

I agree! Fixed in 054f8f0

DeviantBadge · 2019-07-20T22:21:06Z

src/test/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExtTest.kt

+/**
+ * @author doyaaaaaken
+ */
+class RequestExtTest {


I remember that you will write more tests after our approval, but small comment - you should focus your attention on headers and also cookies

DeviantBadge · 2019-07-20T22:30:30Z

Good changes, you are on the right way, @doyaaaaaken

codecov · 2019-07-23T12:04:48Z

Codecov Report

Merging #141 into master will increase coverage by 0.31%.
The diff coverage is 96.55%.

@@             Coverage Diff             @@
##             master    #141      +/-   ##
===========================================
+ Coverage     90.59%   90.9%   +0.31%     
- Complexity      120     130      +10     
===========================================
  Files            40      42       +2     
  Lines           372     396      +24     
  Branches         45      45              
===========================================
+ Hits            337     360      +23     
  Misses            9       9              
- Partials         26      27       +1

Impacted Files	Coverage Δ	Complexity Δ
...kohttp/interceptors/logging/HttpLoggingStrategy.kt	`100% <100%> (ø)`	`3 <3> (?)`
...balkinsd/kohttp/interceptors/LoggingInterceptor.kt	`100% <100%> (ø)`	`2 <1> (-1)`	⬇️
...kohttp/interceptors/logging/CurlLoggingStrategy.kt	`95% <95%> (ø)`	`8 <8> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6dfcba...c64641a. Read the comment docs.

doyaaaaaken

@doyaaaaaken Thank you your feedback!

doyaaaaaken · 2019-07-23T12:00:52Z

README.md

@@ -345,14 +345,15 @@ val forkedClient = defaultHttpClient.fork {
    A Request Logging Interceptor. 

    Parameters:
-    1.  `log: (String) -> Unit = ::println`:  function as a parameter to consume the log message. It defaults to `println`. Logs Request body when present.
+    1.  `outputCurlCommand: Boolean = false`:  if it's true, output curl command on log message.
+    2.  `log: (String) -> Unit = ::println`:  function as a parameter to consume the log message. It defaults to `println`. Logs Request body when present.


Because, log argument is function, this argument order cannot break code.
Below code is working correctly.

val client = defaultHttpClient.fork { interceptors { ///////old version code (outputCurlCommand argument does not exist)////// //no argument +LoggingInterceptor() //only log argument: +LoggingInterceptor { log -> println(log) } ///////new version code (outputCurlCommand argument exists)////// //only outputCurlCommand +LoggingInterceptor(true) //outputCurlCommand and log arguments: +LoggingInterceptor(true) { log -> println(log) } } }

I think log is function and need two or more line's code, so this order is better.
What do you think about it?

doyaaaaaken · 2019-07-23T12:05:06Z

src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt

+                val command = request.buildCurlCommand()
+                log("╭--- cURL command -------------------------------")
+                log(command)
+                log("╰--- (copy and paste the above line to a terminal)")


I agree! Fixed in 054f8f0

rybalkinsd

Hi all,

I had 10 mins to have a look at this PR. General direction is good! And I have several suggestions and questions to think about:

Do we really want to mix Log and Curl interceptors?
If we do - outputCurlCommand: Boolean seems to be not the best choice. Imagine we will decide to print pure HTTP request (not curl, or log) in the future

doyaaaaaken · 2019-07-26T03:54:32Z

@rybalkinsd

Do we really want to mix Log and Curl interceptors?

Yes, I think so, because the responsibility of LoggingInterceptor is to intercept logging process and to customize the way of logging (log message, log output target, etc...).
This responsibility contains to output curl command log.

If we do - outputCurlCommand: Boolean seems to be not the best choice. Imagine we will decide to print pure HTTP request (not curl, or log) in the future

Yes, I agree.
How do you think about below LoggingInterceptor class signature.
The idea is to add setOutputCurlCommand(boolean) method in LoggingInterceptor, instead of outputCurlCommand constructor parameter.

val client = defaultHttpClient.fork {
    interceptors {
       // old version code
       +LoggingInterceptor()
        +LoggingInterceptor { msg ->
            println(msg)
         }
       // new version code
       +LoggingInterceptor().setOutputCurlCommand(true)
       +LoggingInterceptor { msg ->
            println(msg)
         }.setOutputCurlCommand(true)
}

rybalkinsd · 2019-07-27T15:42:04Z

I would recommend to think about enum of output strategies: plain http, curl, m/b something else.

Our top priority is to make a DSL.
That’s the main reason I would recommend not to create methods like .setOutput...() and choose function parameter with good default value.

doyaaaaaken · 2019-07-28T04:30:52Z

@rybalkinsd

I see! So how about below LoggingInterceptor class signature?

class LoggingInterceptor(
        private val formats: List<LoggingFormat> = listOf(LoggingFormat.PLAIN),
        private val log: (String) -> Unit = ::println
) : Interceptor { 
//...
}

enum LoggingFormat { PLAIN, CURL_COMMAND }

rybalkinsd · 2019-07-28T10:38:59Z

@doyaaaaaken

It looks much more user friendly!
I would suggest to use single format. Also probably need to think about better name instead of ‘PLAIN’ - any ideas?

 class LoggingInterceptor(
         private val format: LoggingFormat = PLAIN,
         private val log: (String) -> Unit = ::println
 ) : Interceptor { }

enum LoggingFormat { PLAIN, CURL }

@DeviantBadge your opinion?

doyaaaaaken · 2019-07-29T02:31:37Z

I come up with the enum name candidates: DEFAULT, NATIVE, SUMMARY, ORIGINAL.
But any doesn't fit, so please decide any you want.

rybalkinsd · 2019-07-30T13:52:35Z

@doyaaaaaken I take some time to think about. And come up with HTTP and CURL at the beginning. HTTP should be a default. Currently we don’t have a correct HTTP logging, we should implement it in a different issue, replacing the current default.

So let’s

introduce enum in this PR
Change interceptor signature
Put HTTP as default
Make TODO in default implementation
Make correct implementation for CURL
Create an issue to implement HTTP
Make sure we have uptodate tests

…utputCurlCommand`

doyaaaaaken

@rybalkinsd
I improved my code!

Create an issue to implement HTTP

This issue should be created after this PR will be merged. So, I don't create it yet.

doyaaaaaken · 2019-07-31T14:33:00Z

src/test/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptorTest.kt

@@ -55,4 +55,16 @@ class LoggingInterceptorTest {
        assertEquals(200, response.code())
    }

+    @Test
+    fun `curl command logging happens without exceptions `() {


This test's output is below.

GET 200 - 1118ms https://postman-echo.com/get ╭--- cURL command ------------------------------- curl -X GET "https://postman-echo.com/get" ╰--- (copy and paste the above line to a terminal)

And a test result in the case of LoggingFormat.HTTP is below.

POST 200 - 2076ms http://postman-echo.com/post --80d27159-868d-4252-8b65-392dd2596483 Content-Disposition: form-data; name="file"; filename="cat.gif" Content-Length: 1046038 ��"��#��+'!5+!95/=1"F;1H7%LB4LG@T��YL?ZH3]SE^YThUAh`Wm]HpbRqh`t��xaHxtp}nc}ys~jS~mZ�iK�|u�u`��7�{m�w^��~�z^��s��e��{��g��F��r��{��]��¸�Ʋ��þ��|�ɡ��!��NETSCAPE2.0��!�� -"��Q�]t�ZB��C��x�q��w#�4� qߋR9� M! �?��8��+[򒜂+��I�d"F�P��seiqSXa�b��=e�e(��c�/��z骎�j�*�6��e�O�v��a ��w��de�\��>YU:��A�4��z?�8� Z�ϸߓ� �^�'+ �� -c�f"4��oG�ID�9[��\�9�� h� �07�%�HڥX堟� M]�n�p��P:t�r^�-�BI$�F��{ ......... skip the rest

rybalkinsd · 2019-07-31T15:37:06Z

Great! That looks much better in terms of DevX.
let me have a look at code in next two days.

rybalkinsd

@doyaaaaaken
We're close to making it production-ready. So, let's review the thing I mentioned.

I also suggest you to sign in our Gitter channel to get some discussions if you'll need

rybalkinsd · 2019-08-01T10:56:54Z

README.md


    Usage: 

    ```kotlin
    val client = defaultHttpClient.fork {
                    interceptors {
-                        +LoggingInterceptor()
+                        +LoggingInterceptor(false)


this change looks outdated now

rybalkinsd · 2019-08-01T10:58:54Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+ * @author doyaaaaaken
+ */
+internal fun Request.buildCurlCommand(): String {
+    return StringBuilder().apply {


I suggest to avoid a big-big builder scope here.

we also have buildString to simplify

rybalkinsd · 2019-08-01T11:00:00Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+
+        //headers
+        val headers = headers()
+        for (i in 0 until headers.size()) {


we have asSequence() method for headers

rybalkinsd · 2019-08-01T11:02:28Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+        for (i in 0 until headers.size()) {
+            val name = headers.name(i)
+            var value = headers.value(i)
+            if (value[0] == '"' && value[value.length - 1] == '"') {


this segment of code looks rather complicated for me, probably it will be easier with the sequence, or will need further simplification

please check .last() and .first() methods

rybalkinsd · 2019-08-01T11:03:09Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+            val name = headers.name(i)
+            var value = headers.value(i)
+            if (value[0] == '"' && value[value.length - 1] == '"') {
+                value = "\\\"" + value.substring(1, value.length - 1) + "\\\""


probably, """ string""" triple quoted string will look better here

rybalkinsd · 2019-08-01T11:04:34Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+        }
+
+        //body
+        body()?.let {


please double-check LoggingInterceptor. it looks like a code duplication

rybalkinsd · 2019-08-01T11:06:24Z

src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt

            }
        }
    }
+
+    private fun logAsHttp(request: Request) {


I suggest to refactor as a strategy pattern.

rybalkinsd · 2019-08-01T11:07:07Z

src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt

+
+    private fun logAsCurl(request: Request) {
+        val command = request.buildCurlCommand()
+        log("╭--- cURL command -------------------------------")


It's much better to keep the identical output style for both http and curl

here we don't really know the user's screen width, so ---- line m/b too long

rybalkinsd · 2019-08-01T11:12:13Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+ *
+ * @author doyaaaaaken
+ */
+internal fun Request.buildCurlCommand(): String {


After reading PR several times, I want to ask if we really need this ext function, or we simply can split it into several methods within strategy pattern, as I mentioned in another comment and put it close to the LogginInterceptor package?

doyaaaaaken · 2019-08-02T04:53:55Z

Thank you! Let me have time to look at this from next Sunday.

…

On Thu, Aug 1, 2019, 20:14 Sergei Rybalkin ***@***.***> wrote: ***@***.**** requested changes on this pull request. @doyaaaaaken <https://github.com/doyaaaaaken> We're close to making it production-ready. So, let's review the thing I mentioned. I also suggest you to sign in our Gitter channel to get some discussions if you'll need ------------------------------ In README.md <#141 (comment)>: > Usage: ```kotlin val client = defaultHttpClient.fork { interceptors { - +LoggingInterceptor() + +LoggingInterceptor(false) this change looks outdated now ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt <#141 (comment)>: > @@ -0,0 +1,38 @@ +package io.github.rybalkinsd.kohttp.ext + +import okhttp3.Request +import okio.Buffer +import java.nio.charset.Charset + +/** + * Build curl command of the request + * + * @author doyaaaaaken + */ +internal fun Request.buildCurlCommand(): String { + return StringBuilder().apply { 1. I suggest to avoid a big-big builder scope here. 2. we also have buildString to simplify ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt <#141 (comment)>: > +import okhttp3.Request +import okio.Buffer +import java.nio.charset.Charset + +/** + * Build curl command of the request + * + * @author doyaaaaaken + */ +internal fun Request.buildCurlCommand(): String { + return StringBuilder().apply { + append("curl -X ${method()}") + + //headers + val headers = headers() + for (i in 0 until headers.size()) { we have asSequence() method for headers ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt <#141 (comment)>: > + +/** + * Build curl command of the request + * + * @author doyaaaaaken + */ +internal fun Request.buildCurlCommand(): String { + return StringBuilder().apply { + append("curl -X ${method()}") + + //headers + val headers = headers() + for (i in 0 until headers.size()) { + val name = headers.name(i) + var value = headers.value(i) + if (value[0] == '"' && value[value.length - 1] == '"') { this segment of code looks rather complicated for me, probably it will be easier with the sequence, or will need further simplification please check .last() and .first() methods ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt <#141 (comment)>: > +/** + * Build curl command of the request + * + * @author doyaaaaaken + */ +internal fun Request.buildCurlCommand(): String { + return StringBuilder().apply { + append("curl -X ${method()}") + + //headers + val headers = headers() + for (i in 0 until headers.size()) { + val name = headers.name(i) + var value = headers.value(i) + if (value[0] == '"' && value[value.length - 1] == '"') { + value = "\\\"" + value.substring(1, value.length - 1) + "\\\"" probably, """ string""" triple quoted string will look better here ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt <#141 (comment)>: > + return StringBuilder().apply { + append("curl -X ${method()}") + + //headers + val headers = headers() + for (i in 0 until headers.size()) { + val name = headers.name(i) + var value = headers.value(i) + if (value[0] == '"' && value[value.length - 1] == '"') { + value = "\\\"" + value.substring(1, value.length - 1) + "\\\"" + } + append(" -H \"$name: $value\"") + } + + //body + body()?.let { please double-check LoggingInterceptor. it looks like a code duplication ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt <#141 (comment)>: > } } } + + private fun logAsHttp(request: Request) { I suggest to refactor as a strategy pattern. ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt <#141 (comment)>: > } } } + + private fun logAsHttp(request: Request) { + //TODO: output http request format log. + // see #141 (comment) + request.headers().asSequence().forEach { log("${it.name}: ${it.value}") } + Buffer().use { + request.body()?.writeTo(it) + log(it.readByteString().utf8()) + } + } + + private fun logAsCurl(request: Request) { + val command = request.buildCurlCommand() + log("╭--- cURL command -------------------------------") It's much better to keep the identical output style for both http and curl ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt <#141 (comment)>: > } } } + + private fun logAsHttp(request: Request) { + //TODO: output http request format log. + // see #141 (comment) + request.headers().asSequence().forEach { log("${it.name}: ${it.value}") } + Buffer().use { + request.body()?.writeTo(it) + log(it.readByteString().utf8()) + } + } + + private fun logAsCurl(request: Request) { + val command = request.buildCurlCommand() + log("╭--- cURL command -------------------------------") here we don't really know the user's screen width, so ---- line m/b too long ------------------------------ In src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt <#141 (comment)>: > @@ -0,0 +1,38 @@ +package io.github.rybalkinsd.kohttp.ext + +import okhttp3.Request +import okio.Buffer +import java.nio.charset.Charset + +/** + * Build curl command of the request + * + * @author doyaaaaaken + */ +internal fun Request.buildCurlCommand(): String { After reading PR several times, I want to ask if we really need this ext function, or we simply can split it into several methods within strategy pattern, as I mentioned in another comment and put it close to the LogginInterceptor package? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#141?email_source=notifications&email_token=ABJNJMMIB5GCZNDKWPO6DXTQCLAPXA5CNFSM4IFNUCB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAIOOLI#pullrequestreview-269543213>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJNJMPVSKCZ2NKP2TZCYU3QCLAPXANCNFSM4IFNUCBQ> .

doyaaaaaken · 2019-08-02T09:32:01Z

I agree with all of your review comments!

Not yet finish to fix, so please wait.
I already finish to fix for the comments attached with 👍 emoji.

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

rybalkinsd · 2019-08-02T10:46:54Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+private fun buildCurlHeaderOption(headers: Headers): String {
+    return headers.asSequence().map { header ->
+        val value = header.value.let { v ->
+            if (v.startsWith('"') && v.endsWith('"')) {


I would suggest introducing private method String.isQuoted()

I agree that's better.
And I suggest String.trimDoubleQuote() method is more simpler? ( ecae2fd )

yes, agreed

rybalkinsd · 2019-08-02T10:50:37Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+}
+
+private fun buildCurlBodyOption(body: RequestBody?): String {
+    return if (body == null) {


Kotlin has a smart casting and also nullability checks.
It's possible to simplify code like this

Suggested change

return if (body == null) {

if (body == null) return ""

and it will be also possible to omit else statement

rybalkinsd · 2019-08-02T10:52:44Z

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

+        val buffer = Buffer().apply { body.writeTo(this) }
+        val utf8 = Charset.forName("UTF-8")
+        val charset = body.contentType()?.charset(utf8) ?: utf8
+        " --data $'" + buffer.readString(charset).replace("\n", "\\n") + "'"


Could you please share why we need to replace \n here?

Also looks like utf-8 should be introduced as a const for both HTTP and CURL at least

utf-8 should be introduced as a const for both HTTP and CURL at least

In case of HTTP, ByteString.utf8() method is used currently.

kohttp/src/main/kotlin/io/github/rybalkinsd/kohttp/interceptors/LoggingInterceptor.kt

Line 49 in 9333601

log(it.readByteString().utf8())

And in case of CURL, we can use Buffer.readUtf8() method in stead of assigning Charset class.
Which do you think better?

Use Charset class. So, I fix logic of HTTP case.

Use Buffer.readUtf8() method. So, I fix logic of CURL case.

Could you please share why we need to replace \n here?

Because we can output curl command in one-liner.

For example, if we wouldn't replace \n, we would output below curl command.

curl -X POST --data $'{ "aa": "bb", "aa1": "bb2" }' "https://postman-echo.com/post"

But , with replacing \n, we could output command as one-liner.

curl -X POST --data $'{\n "aa": "bb",\n "aa1": "bb2"\n}' "https://postman-echo.com/post"

I see, make sense

rybalkinsd · 2019-08-02T10:55:18Z

src/test/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExtTest.kt

+
+    @Test
+    fun `build curl command of request with header`() {
+        val request = Request.Builder()


Probably, we need to introduce Request dsl builder

I cannot find Request dsl builder in existing code.
So, do you mean that we should implement new dsl method like this?

request { url = "https://postman-echo.com/post" post = requestBody { contentType = "application/x-www-form-urlencoded" body = "" } }

yeah, unfortunately, there is no one at the moment.
But I think it's better to introduce it as a separate issue later

Yes, I agree!

rybalkinsd · 2019-08-02T10:57:41Z

@doyaaaaaken
Also added some more thoughts after your changes.
As I see now, it should be possible to target 0.11.0 version with this PR

Co-Authored-By: Sergei Rybalkin <yan.brikl@gmail.com>

doyaaaaaken · 2019-08-04T13:18:39Z

@rybalkinsd
Thank you for your detail review! 🙇 I improved code.
Please review it when you have the time.

rybalkinsd

LGFM!

Already fixed

doyaaaaaken added 5 commits July 20, 2019 14:10

output curl command

f2dd2c0

Add description on REAME

f630e9f

build curl command

c5a4bba

test for 'buildCurlCommand' method

28f78a1

make method internal

5a594e2

doyaaaaaken commented Jul 20, 2019

View reviewed changes

DeviantBadge previously requested changes Jul 20, 2019

View reviewed changes

Move logging before sending request

054f8f0

doyaaaaaken commented Jul 23, 2019

View reviewed changes

doyaaaaaken added 3 commits July 23, 2019 21:24

refactor code

eb44f53

Remove --compressed option

a477bd2

Add tests

a0b409e

doyaaaaaken changed the title ~~[WIP] Curl Logging interceptor~~ Curl Logging interceptor Jul 23, 2019

Merge branch 'master' into feature/curl-interceptor

9985b1e

rybalkinsd reviewed Jul 25, 2019

View reviewed changes

Use LoggingFormat enum as LoggingInterceptor argument instead of `o…

aa71422

…utputCurlCommand`

doyaaaaaken commented Jul 31, 2019

View reviewed changes

rybalkinsd requested changes Aug 1, 2019

View reviewed changes

doyaaaaaken added 2 commits August 2, 2019 17:32

Fix outdated description

721d555

Use buildString method instead of StringBuilder

dcff7df

doyaaaaaken added 6 commits August 2, 2019 17:43

Use """ operator

b1191e9

Use Headers.asSequence() method

58ac869

Simplify logic

7722fb0

Fix double quote escape logic bug

54d492c

Simplify logic (make stringBuilder scope smaller)

343950e

improve logging format

9333601

rybalkinsd reviewed Aug 2, 2019

View reviewed changes

src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt Outdated Show resolved Hide resolved

rybalkinsd reviewed Aug 2, 2019

View reviewed changes

doyaaaaaken and others added 8 commits August 3, 2019 11:25

Update src/main/kotlin/io/github/rybalkinsd/kohttp/ext/RequestExt.kt

942cce5

Co-Authored-By: Sergei Rybalkin <yan.brikl@gmail.com>

Fix compile error by previous commit

b21bf81

Refactor: extract private extension method

ecae2fd

Refactor: Use pattern guard

3741fcd

Use strategy pattern

aa8822e

Make LoggingStrategy as first argument of LoggingInterceptor

0f661c9

Delete RequestExt.kt and move logic into CurlLoggingStrategy class

5a5c734

Use 'Buffer.readUtf8()' method

c64641a

rybalkinsd approved these changes Aug 4, 2019

View reviewed changes

rybalkinsd merged commit c88850f into rybalkinsd:master Aug 4, 2019

doyaaaaaken mentioned this pull request Aug 5, 2019

[kohttp] Introduce Request dsl builder #147

Open

Curl Logging interceptor #141

Curl Logging interceptor #141

Conversation

doyaaaaaken commented Jul 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeviantBadge commented Jul 20, 2019

codecov bot commented Jul 23, 2019 • edited Loading

Codecov Report

doyaaaaaken left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rybalkinsd left a comment

Choose a reason for hiding this comment

doyaaaaaken commented Jul 26, 2019

rybalkinsd commented Jul 27, 2019

doyaaaaaken commented Jul 28, 2019

rybalkinsd commented Jul 28, 2019

doyaaaaaken commented Jul 29, 2019 • edited Loading

rybalkinsd commented Jul 30, 2019

doyaaaaaken left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rybalkinsd commented Jul 31, 2019

rybalkinsd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doyaaaaaken commented Aug 2, 2019 via email

doyaaaaaken commented Aug 2, 2019

rybalkinsd Aug 2, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doyaaaaaken Aug 4, 2019 • edited Loading

Choose a reason for hiding this comment

rybalkinsd Aug 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rybalkinsd commented Aug 2, 2019

doyaaaaaken commented Aug 4, 2019

rybalkinsd left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 23, 2019 •

edited

Loading

doyaaaaaken commented Jul 29, 2019 •

edited

Loading

doyaaaaaken left a comment •

edited

Loading

rybalkinsd Aug 2, 2019 •

edited

Loading

doyaaaaaken Aug 4, 2019 •

edited

Loading

rybalkinsd Aug 4, 2019 •

edited

Loading