Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring of multipart body #148

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

rybalkinsd
Copy link
Owner

No description provided.

@rybalkinsd rybalkinsd changed the title initial refactoring of multipart body WIP: initial refactoring of multipart body Aug 5, 2019
@rybalkinsd rybalkinsd requested a review from DeviantBadge August 6, 2019 12:58
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #148 into feature/128-multimodule will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             feature/128-multimodule     #148      +/-   ##
=============================================================
+ Coverage                      90.48%   90.54%   +0.05%     
  Complexity                       129      129              
=============================================================
  Files                             43       43              
  Lines                            368      370       +2     
  Branches                          43       43              
=============================================================
+ Hits                             333      335       +2     
  Misses                            10       10              
  Partials                          25       25
Impacted Files Coverage Δ Complexity Δ
...hub/rybalkinsd/kohttp/dsl/context/UploadContext.kt 100% <100%> (ø) 6 <0> (ø) ⬇️
...alkinsd/kohttp/dsl/context/MultipartBodyContext.kt 100% <100%> (ø) 7 <3> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757155e...9e7b7a3. Read the comment docs.

@rybalkinsd rybalkinsd changed the title WIP: initial refactoring of multipart body refactoring of multipart body Aug 9, 2019
@rybalkinsd rybalkinsd merged commit f09982e into feature/128-multimodule Aug 9, 2019
rybalkinsd added a commit that referenced this pull request Aug 10, 2019
* poc init

* kohttp-jackson module initial

* introduced kohttp-test project for mixed tests with both kohttp-core & kohttp-jackson & etc in future

* 1. renamed kohttp-core -> kohttp
2. gitignore changes
3. changes in gradle to use jacoco multi-module

* removed eager ext

* Response body ext improvements #132 (#133)

* 1. closing body
2. added explicit types
3. added docs

* changed patch configuration for codcov

* Update kohttp/src/main/kotlin/io/github/rybalkinsd/kohttp/ext/ResponseExt.kt

Co-Authored-By: DeviantBadge <zhenya_vorobyov@mail.ru>

* Update kohttp/src/main/kotlin/io/github/rybalkinsd/kohttp/ext/ResponseExt.kt

Co-Authored-By: DeviantBadge <zhenya_vorobyov@mail.ru>

* rebase fixes with `asJson`

* build gradle publication fixes

* fix: escape \r in curl logging

* initial refactoring of multipart body (#148)

* initial refactoring of multipart body

* fixed UploadContext implementation

* updated multipart example

* removing config default client with yaml feature

* Changed asJson() behavior when body is null or empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant