Require and validate mac address at the cli #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 23, 2017
eq3bt/eq3cli.py
Outdated
| @@ -8,8 +8,13 @@ | |||
| pass_dev = click.make_pass_decorator(Thermostat) | |||
|
|
|||
|
|
|||
| def validate_mac(ctx, param, mac): | |||
| if None == re.match('^([0-9A-Fa-f]{2}:){5}[0-9A-Fa-f]{2}$', mac): | |||
There was a problem hiding this comment.
comparison to None should be 'if cond is None:'
undefined name 're'
klemens
force-pushed
the
cli-validate-mac
branch
from
b902337
to
d3b626e
Compare
|
Looks good, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a click validation function and makes the mac argument required (also works when passed using the environment variable).
This does not add any validation to the library itself, but you can easily catch the
ValueErrorexception yourself, and validating using a regular expression is probably overkill, as the mac usually comes from a config when using the library and was already validated elsewhere.