Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 14/UI c 3082/phcoval/node/main #14

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

rzr
Copy link
Owner

@rzr rzr commented Apr 24, 2024

Change

Checklist

rzr and others added 16 commits January 17, 2024 22:26
More to be tested

Bug-SiliconLabs: UIC-3082
Bug-GitHub: #3
Origin: https://github.com/rzr/UnifySDK/tree/GH-14/UIC-3082/phcoval/main
Forwarded: SiliconLabs#26
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Fixes bug where Attribute [0x3208] Value can not get resolved for legacy devices.
Size of ZW_METER_GET_V3_FRAME is smaller than size of ZW_METER_GET_V5_FRAME.
Legacy device supporting COMMAND_CLASS_METER_V3 and below will ignore received V5 frames,
because frame size is larger than expected.

Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
…s of CC

Bug-SiliconLabs: UIC-3082
Origin: https://github.com/rzr/UnifySDK/tree/GH-20/UIC-3082/phcoval/main
Relate-to: nkljajic#1
Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-20/develop
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Fix a mismatch between value in Rust and value defined in C header:
zpc_attribute_store/include/attribute_store_defined_attribute_types.h

Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
Some S0 multichannel endpoints will not respond to multichannel encapsulated
SECURITY_COMMANDS_SUPPORTED_GET command [ 60 0D 00 01 98 02 ].
In such case, copy endpoint NIF to Secure NIF.

For reference, see:
Z-Wave Transport-Encapsulation Command Class Specification
3.5.4.1 Multi Channel Handling

The implicit rule that all non-secure command classes for an End Point must be controllable
securely is still in effect, if the endpoint is reported secure.

Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
SiliconLabsGH-22 add a new callback on the give_up_listener on the ATTRIBUTE_ZWAVE_SECURE_NIF attribute causing the test case to fail.

The test only expect this listener to be called on the non-secure NIF ATTRIBUTE_ZWAVE_NIF. This change make sure that the code is only executed in the context of ATTRIBUTE_ZWAVE_NIF and ignored  for ATTRIBUTE_ZWAVE_SECURE_NIF as this test don't care about it.

Bug-SiliconLabs: UIC-3082
Relate-to: SiliconLabs#22
Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-22/develop
Bug-SiliconLabs: UIC-3082
Relate-to: SiliconLabs#22
Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-22/develop
Origin: silabs-borisl#2
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Duration can be any value in the range 0x01..0xFD.

For reference, see:
CC:0000.00.00.11.015
CC:0033.02.05.11.007

Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
Bug-SiliconLabs: UIC-3082
Relate-to: SiliconLabs#24
Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop
Origin: nkljajic#5
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
(cherry picked from commit 7cf96bbd299634ed7bc393eae1d017bf5bf07d21)

Bug-SiliconLabs: UIC-3082
Relate-to: SiliconLabs#24
Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop
Origin: nkljajic#5
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Bug-SiliconLabs: UIC-3082
Bug-GitHub: SiliconLabs#15
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
(cherry picked from commit 861d661)
Note this is currently active in forked repos

Bug-SiliconLabs: UIC-3082
Bug-GitHub: #3
Forwarded: SiliconLabs#14
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants