Gh 14/UI c 3082/phcoval/node/main #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More to be tested Bug-SiliconLabs: UIC-3082 Bug-GitHub: #3 Origin: https://github.com/rzr/UnifySDK/tree/GH-14/UIC-3082/phcoval/main Forwarded: SiliconLabs#26 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Fixes bug where Attribute [0x3208] Value can not get resolved for legacy devices. Size of ZW_METER_GET_V3_FRAME is smaller than size of ZW_METER_GET_V5_FRAME. Legacy device supporting COMMAND_CLASS_METER_V3 and below will ignore received V5 frames, because frame size is larger than expected. Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
…s of CC Bug-SiliconLabs: UIC-3082 Origin: https://github.com/rzr/UnifySDK/tree/GH-20/UIC-3082/phcoval/main Relate-to: nkljajic#1 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-20/develop Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Fix a mismatch between value in Rust and value defined in C header: zpc_attribute_store/include/attribute_store_defined_attribute_types.h Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
Some S0 multichannel endpoints will not respond to multichannel encapsulated SECURITY_COMMANDS_SUPPORTED_GET command [ 60 0D 00 01 98 02 ]. In such case, copy endpoint NIF to Secure NIF. For reference, see: Z-Wave Transport-Encapsulation Command Class Specification 3.5.4.1 Multi Channel Handling The implicit rule that all non-secure command classes for an End Point must be controllable securely is still in effect, if the endpoint is reported secure. Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
SiliconLabsGH-22 add a new callback on the give_up_listener on the ATTRIBUTE_ZWAVE_SECURE_NIF attribute causing the test case to fail. The test only expect this listener to be called on the non-secure NIF ATTRIBUTE_ZWAVE_NIF. This change make sure that the code is only executed in the context of ATTRIBUTE_ZWAVE_NIF and ignored for ATTRIBUTE_ZWAVE_SECURE_NIF as this test don't care about it. Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#22 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-22/develop
Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#22 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-22/develop Origin: silabs-borisl#2 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Duration can be any value in the range 0x01..0xFD. For reference, see: CC:0000.00.00.11.015 CC:0033.02.05.11.007 Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: nkljajic#5 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Signed-off-by: Philippe Coval <philippe.coval@silabs.com> (cherry picked from commit 7cf96bbd299634ed7bc393eae1d017bf5bf07d21) Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#24 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-24/develop Origin: nkljajic#5 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Bug-SiliconLabs: UIC-3082 Bug-GitHub: SiliconLabs#15 Signed-off-by: Philippe Coval <philippe.coval@silabs.com> (cherry picked from commit 861d661)
Note this is currently active in forked repos Bug-SiliconLabs: UIC-3082 Bug-GitHub: #3 Forwarded: SiliconLabs#14 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…ameter. When 'Parameter Number' and 'Next Parameter Number' are equal, configuration parameter discovery can not complete. For example, this Z-Wave frame will set Node Interview into an infinite loop: 70 : COMMAND_CLASS_CONFIGURATION 0F : CONFIGURATION_PROPERTIES_REPORT_V4 00 : Parameter Number 1 (MSB) 71 : Parameter Number 2 (LSB) 09 : Format 0x01 Unsigned Integer, size 0x1 01 : Min Value 64 : Max Value 0A : Default Value 00 : Next Parameter Number (MSB) 71 : Next Parameter Number (LSB) 02 : No Bulk support 0x1, Not Advanced Parameter 0x0 Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
First time we use COMMAND_CLASS_VERSION, query its own version supported. Prioritize COMMAND_CLASS_MANUFACTURER_SPECIFIC before others. UAM rules can match unique device model, so we could override supported command class version attributes for matching device model. Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
…inutes In ver_1.0.0 intended value was supposed to be 24 hours, as indicated by its comment. During refactoring this comment was lost, so value incorrectly remained 24 minutes. Interval of 24 minutes to ping failing device seems arbitrary and too short. Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
rzr
force-pushed
the
GH-14/UIC-3082/phcoval/node/main
branch
from
13fa921
to
d57e60c
Compare
Also align to distro stable version: 1.22.19+~cs24.27.18-2+deb12u1 Currently there is no backport of recent version, so let´s align to debian https://tracker.debian.org/pkg/node-yarnpkg Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
force-pushed
the
GH-14/UIC-3082/phcoval/node/main
branch
from
d57e60c
to
a6d7afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Checklist