-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearify how templates work (and use a better default name) #46
Comments
After looking into the code, I think this is a missunderstanding with the following root cause: It suggests that the directory holds configs for i3wm (when it is meant to hold all configs that are relevant to a i3wm setup). I have seen multiple questions from people (me included) who were irritated that configfiles for Xdefaults in a directory called i3 or even wondered when Themer would support other window managers than i3. I suggest to rename it to |
@Kaligule you are correct with the second comment, this is a relic from when I ported the original code here and lazily never changed this. I think it makes more sense to just completely remove that hierarchy-layer maybe, it is problematic anyway because if you only use one setup you have to either use the default name or specify it every time. Another angle at this is that actually this is all user configuration and only supposed to be an example configuration. Maybe it should even be removed from the package and put into a wiki or seperate repo, what do you think? |
It might be usefull to ship some example configuration, but maybe it should go to I think removing the layer sounds like a good idea. I tried very hard but couldn't really think of a problem it solves that couldn't be solved easier otherwise. |
@s-ol I have thought about it a little more and want to suggest the following setup (for a working setup, we could think about files shiped by default later).
I see that the changes would be massive, though. Any thoughts on that? |
A more radical approach, but maybe the right one, would be to completely remove all the These are quite some changes, but not 'too huge to do'. I was planning on eventually radically rewriting themer but never got around to, and this seems like a middle ground and a good way of changing it from within. |
Good ideas. Wow.
If you start working on this I will try to help when I find the time for it.
|
Oh, and another point to having the real files in |
@Kaligule yup, that's what I meant to say by
|
I'm going to close this and break it into smaller changes. |
Close #47 and #46 commit e365277 Author: Jøhannes Lippmann <code@schauderbasis.de> Date: Mon Apr 10 19:10:29 2017 +0200 Make clearer which files you are intended to use. commit 348c278 Author: Jøhannes Lippmann <code@schauderbasis.de> Date: Sat Apr 8 17:51:41 2017 +0200 little fix in README commit fbf4314 Author: Jøhannes Lippmann <code@schauderbasis.de> Date: Sat Apr 8 17:49:26 2017 +0200 Remove foodnote since they are not supported it Github. What has Github flavoured Markdown ever done for us? commit 473f01d Author: Jøhannes Lippmann <code@schauderbasis.de> Date: Sat Apr 8 17:43:21 2017 +0200 Improve documentation. After learning a bit more about Themer (by actually using it) some corrections to the documentation seemed appropriate. commit 4091ddd Author: Jøhannes Lippmann <code@schauderbasis.de> Date: Sat Apr 8 12:14:00 2017 +0200 Small addition in README. Trimmed lines so they are not too long anymore. commit 42f6510 Author: Jøhannes Lippmann <code@schauderbasis.de> Date: Sat Apr 8 11:11:01 2017 +0200 Documentation on the directury structure of themer. I wrote this without being sure it is correct (most of it is actually guessed). I am sure mor documentation is needed though. It would be nice if someone would have a second look at it.
After instalation of themer I have the following structure in my
.config/themer/templates
It is unclear to me (and not explained in the readme or elsewhere) why there is an Xdefaults template in the i3 directory. Shouldn't there only be i3-related files in there? I had expected something like:
Or perhaps:
So it would be great if the readme could explain how the template directory should work and what goes into the config.
The text was updated successfully, but these errors were encountered: