Pure python2.7 compatibility #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Had issues with missing dependency for requests - Had errors/warnings for mechanize performance if not using the python-Levenshtein dependency. Install removed warning. Believe this was a performance optimization for prettytable - Added versions for stability/compatibility and ease of installation
Had issues with the mixture of some Python2.7 and Python3 packages, so I made the project completely depdendent only on Python2.7 with the following changes: I chose to go with the Python2.7 requirement over Python3 because the `mechanize` library has no Python3 compatible version. - Use Python2.7 urllib and urlparse libraries for compatible functionality of the python3 urllib merged library - Updated all `input` methods to `raw_input` to fix type errors for user input - Change test from `builtins.zip` to `future_builtins.zip` which was added to Python2.7 since the library was coming to Python3 - Correct misleading error message about version of python noting Python2.7 requirement I have tested all changes in a clean Python2.7 virtualenv and to my knowledge all functionality is intact with the changes.
Closed
|
Will resolve #41 if accepted. 😃 |
|
I am sorry but I tried to drop Python 2 support in the latest release so I can't merge this one. |
|
All about moving forward with Python3, the problem is that the I guess I could be more helpful by looking at what Release today looks great btw, great refactor! |
|
I know and I replaced mechanize with requests already ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See full details commit history but there were issues in installation with the mixture of Python3 and Python2.7 libraries/environment so I refactored to be dependent on Python2.7 only due to the hard requirement of the
mechanizelibrary which would need to be replaced for Python3 compatibility.Awesome tool, hope this helps! 🎈