Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with selectAllOnlyVisible and empty filtered list #287

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Fix issue with selectAllOnlyVisible and empty filtered list #287

merged 1 commit into from
Dec 28, 2023

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Oct 26, 2023

This PR aims to fix an issue with selectAllOnlyVisible:true and empty filtered lists.

What was happening

  • When using selectAllOnlyVisible:true having multiple selection and search
    • options like these:
      image
  • Selected one option
  • Filtered by an unexisting word
  • The list is empty but the select all checkbox was being checked - ❌
    selectAllOnlyVisible_EmptySearchIssue

After the fix

  • Followed the same steps above - ✅
  • Ran regression scenarios - ✅
  • Run automated tests - ✅

image

It is now working as expected:

selectAllOnlyVisible_EmptySearchIssueFix

@gnbm
Fix issue with selectAllOnlyVisible and empty filtered list
f120107 
Fixed issue with selectAllOnlyVisible and empty filtered list
@gnbm gnbm requested a review from sa-si-dev October 26, 2023 19:50
@gnbm
Copy link
Collaborator Author

gnbm commented Nov 27, 2023

@sa-si-dev Any updated about the review of this PR?

@gnbm gnbm merged commit 63b1be0 into sa-si-dev:master Dec 28, 2023
@gnbm gnbm mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@sa-si-dev sa-si-dev Awaiting requested review from sa-si-dev

Assignees

@sa-si-dev sa-si-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnbm @BenOsodrac @sa-si-dev