Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin strengthening screenshot PR #1

Merged
merged 22 commits into from
Apr 4, 2024
Merged

Begin strengthening screenshot PR #1

merged 22 commits into from
Apr 4, 2024

Conversation

pushfoo
Copy link

@pushfoo pushfoo commented Mar 31, 2024 •
edited
Loading

TL;DR: Starts cleaning it up per review in cal of my initial changes + yours

Changes

  • Use pytest's built-in temp dir helper (Sorry about that! I had to look it up on a hunch!)
  • Add fallback timestamp helper
  • Add start of programming guide pages on screenshots + doc
    • Add example which accounts for TRANSPARENT_BLACK bg breaking screenshots
    • Recommend Arrow and other datetime replacements
    • Add cross-referencing between logging and screenshot doc
  • Use flexible PIL.Image.save-style params
  • Add new doc to home page toctree

@pushfoo
Use cleaner pytest screenshot fixtures
3472eab
@pushfoo
Try to make Window.save_screenshot friendlier + better documented
d38d28e
@pushfoo
Use shorter intersphinx mapping instead of full URL
b104c00
@pushfoo
Phrasing tweak for Window.save_screenshot docstring
931075e
@pushfoo
Sync implementation + docstring for window_command.save_screenshot
6811519
@pushfoo
Use intersphinx link in screenshot kwargs field
b377f88
@pushfoo
Add Window.save_timestamped_screenshot method + doc
0dcdcf1
@pushfoo
Add creenshot / helper doc, helpers, and examples
161566e 
* Add screenshot overview + example

* Add HasStrftime Protocol type

* Add arcade.get_timestamp

* Add some cross-referencing between logging and other doc

* Add doc on datetime replacements which are nicer for filename templating
@pushfoo
Revert get_timestamped_screenshot
29ccec7
@pushfoo
Spacing in Window.__init__
2b74056
@pushfoo
Revert whitespace noise in application.py
f70685a
@pushfoo
Commit overlooked example py file + screenshot for doc
6741ea9
@pushfoo
Fix code-block directive spacing
eb900a6
@pushfoo pushfoo changed the title Begin cleaning up screenshot PR Begin strengthening screenshot PR Mar 31, 2024
@pushfoo
Better date and time section tweaks
b6b5341 
* Fix typo in first line

* Remove compaction of arcade.get_timestamp link
@pushfoo
Intro block revision
b53b413
@pushfoo
Second pair of intro tweaks
c42872a 
* Remove extra sentence

* Add list item linking the better datetime overview
sabadam32
sabadam32 reviewed Mar 31, 2024
View reviewed changes
arcade/__init__.py Show resolved Hide resolved
arcade/types.py Show resolved Hide resolved
@pushfoo
Add module-level spacing above get_timestamp
ae00a90
@pushfoo
Put format string first in get_timestamp
2dfd5b5
@pushfoo
Add tzinfo to get_timestamp
09a363e
@pushfoo
Account for DX + Sabadam32's suggestions
50d38ee 
* Re-order arguments for get_timestamp

* Improve default timestamp format string

* Add time-machine test helper to pyproject.toml

* Add tests for get_timestamp

* Update doc to cover changes
@pushfoo
Add timezone to format string + clean up tests
e6a708a 
* Add %Z to get_timestamp

* Add doc on it + cross-refs

* Clean datetime test imports
@pushfoo
Phrasing tweak to intro
d7eeecb
@pushfoo pushfoo requested a review from sabadam32 April 3, 2024 23:38
@sabadam32 sabadam32 merged commit 8e92ac5 into sabadam32:add_screenshot_1342 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabadam32 sabadam32 sabadam32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushfoo @sabadam32