Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Strict Error if Response Body Empty #125

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Fix Strict Error if Response Body Empty #125

merged 2 commits into from
Sep 12, 2019

Conversation

WorksDev
Copy link
Contributor

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #125   +/-   ##
=========================================
  Coverage     93.52%   93.52%           
- Complexity      251      252    +1     
=========================================
  Files            15       15           
  Lines           819      819           
=========================================
  Hits            766      766           
  Misses           53       53
Impacted Files Coverage Δ Complexity Δ
lib/RequestDecorator.php 100% <100%> (ø) 16 <1> (ø) ⬇️
lib/Client.php 83.85% <100%> (ø) 58 <6> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4125c77...f0d5c18. Read the comment docs.

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for your contribution.

we cannot uplift the php min-version without doing a new major version.

the implemented solution needs to be php 7.0 compatible

lib/Client.php Outdated Show resolved Hide resolved
@staabm
Copy link
Member

staabm commented Sep 12, 2019

I really like how this patch looks like right now. I think this is the way to go.

The alternative patch is in #127

@DeepDiver1975 @evert any input

@staabm
Copy link
Member

staabm commented Sep 12, 2019

@WorksDev could you cherry pick the unit test from #127 ?

@DeepDiver1975
Copy link
Member

I really like how this patch looks like right now. I think this is the way to go.

I prefer this one over #127 - default value on the second argument looks very odd.

@WorksDev could you cherry pick the unit test from #127 ?

Yes please - we need tests.

THX a lot

@WorksDev
Copy link
Contributor Author

@staabm @DeepDiver1975 Tests are taken from #127

@staabm staabm merged commit 2a85ffb into sabre-io:master Sep 12, 2019
@staabm
Copy link
Member

staabm commented Sep 12, 2019

awesome thx

@staabm
Copy link
Member

staabm commented Sep 12, 2019

prepareing 5.0.2 right now in #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError if Response Body Empty
4 participants