-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Strict Error if Response Body Empty #125
Conversation
WorksDev
commented
Sep 12, 2019
- fixes TypeError if Response Body Empty #124
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=========================================
Coverage 93.52% 93.52%
- Complexity 251 252 +1
=========================================
Files 15 15
Lines 819 819
=========================================
Hits 766 766
Misses 53 53
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for your contribution.
we cannot uplift the php min-version without doing a new major version.
the implemented solution needs to be php 7.0 compatible
I really like how this patch looks like right now. I think this is the way to go. The alternative patch is in #127 @DeepDiver1975 @evert any input |
- fixes #124 - Test taken from #127 ty @phil-davis
@staabm @DeepDiver1975 Tests are taken from #127 |
awesome thx |
prepareing 5.0.2 right now in #128 |