Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in text of status code 203 'Non-Authoritative Information' #189

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 15, 2022

This typo is in a public static array. If HTTP status 203 is ever used/returned, then the typo-fix means that the associated text will be slightly different. I guess nobody will depend on the typo "Non-Authorative"?

@phil-davis phil-davis requested a review from staabm July 15, 2022 12:37
@phil-davis phil-davis self-assigned this Jul 15, 2022
@phil-davis
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #189 (be3b7f4) into master (65af520) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #189   +/-   ##
=========================================
  Coverage     94.11%   94.11%           
  Complexity      260      260           
=========================================
  Files            15       15           
  Lines           884      884           
=========================================
  Hits            832      832           
  Misses           52       52           
Impacted Files Coverage Δ
lib/Response.php 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string is defined in the spec. When someone dependa on it it needs to change to comply with the spec

@phil-davis phil-davis merged commit 87fbcab into sabre-io:master Jul 15, 2022
@phil-davis phil-davis deleted the Non-Authoritative branch July 15, 2022 14:01
@evert
Copy link
Member

evert commented Jul 15, 2022

Whoops!

It shouldn't matter though. The text is informative and is actually stripped entirely over HTTP/2.

But fun fact, there was a webdav client out there that relied on the spelling to be 200 OK and not 200 Ok and it took a LONG WHILE to figure out why it didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants