support http2 #84
support http2 #84
Conversation
|
@staabm Can you help me fix that error, please? |
tests/HTTP/SapiTest.php
Outdated
| function testRecognizeHttp2() { | ||
| $request = Sapi::createFromServerArray([ | ||
| 'SERVER_PROTOCOL' => 'HTTP/2.0', | ||
| 'REQUEST_URI' => 'bla' |
There was a problem hiding this comment.
Misses REQUEST_METHOD e.g. GET
.gitignore
Outdated
| # Binaries | ||
| bin/php-cs-fixer* | ||
| bin/phpunit* | ||
| bin/sabre-cs-fixer* |
There was a problem hiding this comment.
Those are already contained, see above
There was a problem hiding this comment.
But the .bat equalivants aren't. I think I'll fix it.
|
Why are the tests still failing? |
|
see https://travis-ci.org/fruux/sabre-http/jobs/257649768 seems to be a phpunit issue, unrelated to your PR. |
|
So you're going to merge it soon? |
| @@ -6,10 +6,10 @@ composer.lock | |||
| tests/cov/ | |||
|
|
|||
| # Composer binaries | |||
| bin/phpunit | |||
There was a problem hiding this comment.
please drop all your changes from the gitignore
There was a problem hiding this comment.
But then I'm going to commit the .bat binaries.
There was a problem hiding this comment.
This prevents that I'm committing these files:
|
yep |
|
thx |
|
When will you publish a new version? I need this feature 😆 |
|
as I read the trunk changelog, it will be version 5. as this is the only one which will allow BC breaks I need to wait for @evert and what he likes to break in this release. alternatively we could cherry pick into a 4.x version. lets see what his opinion is. |
|
Okay, thanks. |
I added the binaries files, that will be installed once you install the dependencies, to the
gitignorefile.fixes #81