Executing multiple PUT requests makes curl emit warnings

[christiaan]

As reported in issue #89
See also this related stack overflow article

[staabm]

Any chance to get a unit test covering the change?

[codecov-io]

Codecov Report

Merging #99 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
- Coverage        89%   88.83%   -0.18%     
  Complexity      244      244              
============================================
  Files            15       15              
  Lines           782      779       -3     
============================================
- Hits            696      692       -4     
- Misses           86       87       +1

Impacted Files	Coverage Δ	Complexity Δ
lib/Client.php	57.31% <0%> (-1.37%)	49 <0> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087ad4b...4a1a958. Read the comment docs.

[christiaan]

I've added a test and removed some previously needed workarounds that were required because CURL_OPTs were persisted between requests. With the introduction of curl_reset those problems are fixed.

Is it worthwhile to also open a PR for the latest stable that fixes this problem? As I've currently got this patched locally to even have my code working

[staabm]

Hmm I guess you accidentally removed the curl_reset() call?

We cannot add the same patch on the latest stable release, because our 4.2 release supports php 5.4 and curl_reset() was added in 5.5

[christiaan]

I tried a different approach before as I did not notice that PHP 7 was now required so I removed the reset.
And of course I forgot to put it back... I've overwritten the commit

[staabm]

Really like it! Lets see what others think

[evert]

LGTM!