-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with php 7.3 #424
Test with php 7.3 #424
Conversation
e0b0626
to
ea7a15c
Compare
@staabm seems like there is no way to test with the current travis config on php 5.5 I vote for removing php 5.5 from travis for now - later we can decide to drop it completly ... Objections? |
I am ok with a "allow failures" travis config for php5.5 (and a separate issue in the issue tracker to maybe solve this problem in the future) |
.travis.yml
Outdated
addons: | ||
apt: | ||
packages: | ||
- libzip4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment when/why we need this
85243f5
to
2f5f131
Compare
Why don't you cut a new major version and drop PHP < 7? Might make your life a bit easier. |
2f5f131
to
7e906bc
Compare
7e906bc
to
f3cc955
Compare
We can drop older version in a followup pr. @staabm merge? We can then tag a new alpha and setup dependencies in other repos properly. |
Thanks |
4.2.0. when we dont drop php5, agree |
No description provided.