Mobile Gateway API #253
Merged
Mobile Gateway API #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implememts fake driver for SIM - Set SIM.IsGlobal=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: mapconvでは内部的にmapを利用してデータ変換を行い、最後にjson.Marshal/json.Unmarshalを行ってmapからstructへ変換していた。
かつモバイルゲートウェイAPIでは一部フィールドでスネークケースとなっているため、naked型へJSONタグを付与して対応していた。
この場合mapconvにおいてJSONタグ起因でうまく変換できないケースがあったため、json.Marshal/Unmarshalの使用をやめmapstructureを利用するように変更した。