This repository has been archived by the owner on Jan 8, 2019. It is now read-only.
Right "go fmt" for whole project and fix some redundant usages #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadlil
suggested changes
Jan 18, 2018
| "github.com/stretchr/testify/assert" | ||
| "os" | ||
| "fmt" | ||
| "testing" |
There was a problem hiding this comment.
Can you do a Proper goimport too??
printer/es/es.go
Outdated
| "strings" | ||
| elastigo "github.com/mattbaird/elastigo/lib" | ||
| "time" |
printerHandler.go
Outdated
| @@ -1,15 +1,15 @@ | |||
| package gologger | |||
|
|
|||
| import ( | |||
| "github.com/sadlil/gologger/logger" | |||
| "github.com/sadlil/gologger/printer" | |||
|
Sure, I will do it soon |
sadlil
suggested changes
Jan 30, 2018
gologger.go
Outdated
| package gologger | ||
|
|
||
| import "github.com/sadlil/gologger/logger" | ||
| package main |
There was a problem hiding this comment.
Can't use package main. By that we can't import it from other package as lib.
There was a problem hiding this comment.
No, It was fixed. It was some wrong commit with it. Look at whole changes in PR. But, I'll do it by one commit.
- Changed panic - Fix goimports - Fatal log
sadlil
approved these changes
Jan 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right "go fmt" for whole project and fix some redundant usages