Add ability to turn off notifications

notifier/config.go

@@ -0,0 +1,73 @@
+package main
+
+import (
+	"github.com/safing/portbase/database/record"
+
+	"github.com/safing/portbase/api/client"
+	"github.com/safing/portbase/log"
+
+	"github.com/tevino/abool"
+)
+
+var (
+	notificationsEnabled = abool.NewBool(true)
+	promptsEnabled       = abool.NewBool(true)
+)
+
+func configClient() {
+	configOp := apiClient.Qsub("query config", handleConfigUpdate)
+	configOp.EnableResuscitation()
+}
+
+func handleConfigUpdate(m *client.Message) {
+	switch m.Type {
+	case client.MsgError:
+		log.Warningf("config: received error message: %s", string(m.RawValue))
+	case client.MsgDone:
+	case client.MsgSuccess:
+	case client.MsgOk, client.MsgUpdate, client.MsgNew:
+
+		// only process these keys
+		switch m.Key {
+		case "config:core/useSystemNotifications":
+		case "config:filter/askWithSystemNotifications":
+		default:
+			return
+		}
+
+		// parse record
+		if len(m.RawValue) < 2 {
+			log.Warningf("notify: failed to parse new config msg %s: too short", m.Key)
+			return
+		}
+		r, err := record.NewWrapper(m.Key, nil, m.RawValue[0], m.RawValue[1:])
+		if err != nil {
+			log.Warningf("notify: failed to parse new config msg %s: %s", m.Key, err)
+			return
+		}
+		acc := r.GetAccessor(r)
+
+		// get value
+		newValue, ok := acc.GetBool("Value")
+		if !ok {
+			newValue, ok = acc.GetBool("DefaultValue")
+			if !ok {
+				log.Warningf("config: could not get Value or DefaultValue from %s", m.Key)
+			}
+		}
+
+		// set value
+		switch m.Key {
+		case "config:core/useSystemNotifications":
+			notificationsEnabled.SetTo(newValue)
+			log.Infof("config: use system notifications set to: %v", newValue)
+		case "config:filter/askWithSystemNotifications":
+			promptsEnabled.SetTo(newValue)
+			log.Infof("config: ask with systemNotifications set to: %v", newValue)
+		}
+
+	case client.MsgDelete:
+	case client.MsgWarning:
+	case client.MsgOffline:
+	}
+}

notifier/main.go

@@ -80,7 +80,11 @@ func main() {
 	databaseDir = dataDir
 
 	// start log writer
-	log.Start()
+	err = log.Start()
+	if err != nil {
+		fmt.Fprintf(os.Stderr, "failed to start logging: %s\n", err)
+		os.Exit(1)
+	}
 
 	// connect to API
 	go apiClient.StayConnected()
@@ -89,10 +93,11 @@ func main() {
 	go tray()
 	go statusClient()
 	go notifClient()
+	go configClient()
 
 	// Shutdown
 	// catch interrupt for clean shutdown
-	signalCh := make(chan os.Signal)
+	signalCh := make(chan os.Signal, 1)
 	signal.Notify(
 		signalCh,
 		os.Interrupt,
@@ -113,16 +118,19 @@ func main() {
 
 	if printStackOnExit {
 		fmt.Println("=== PRINTING STACK ===")
-		pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
+		_ = pprof.Lookup("goroutine").WriteTo(os.Stdout, 2)
 		fmt.Println("=== END STACK ===")
 	}
 	go func() {
 		time.Sleep(10 * time.Second)
 		fmt.Println("===== TAKING TOO LONG FOR SHUTDOWN - PRINTING STACK TRACES =====")
-		pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
+		_ = pprof.Lookup("goroutine").WriteTo(os.Stdout, 2)
 		os.Exit(1)
 	}()
 
+	// clear all notifications
+	clearNotifications()
+
 	// shutdown
 	cancelMainCtx()
 	mainWg.Wait()

notifier/notification.go

@@ -7,8 +7,8 @@ import (
 
 // Notification types
 const (
-	Info    uint8 = 0
-	Warning uint8 = 1
+	Info    uint8 = 0 //nolint:deadcode
+	Warning uint8 = 1 //nolint:deadcode
 	Prompt  uint8 = 2
 )
 

notifier/notify.go

@@ -55,7 +55,18 @@ func handleNotification(m *client.Message) {
 			existing.Unlock()
 		}
 
+		// save
 		notifications[n.ID] = n
+
+		// check if notifications are enabled
+		if !notificationsEnabled.IsSet() {
+			return
+		}
+		// check if prompts are enabled
+		if n.Type == Prompt && !promptsEnabled.IsSet() {
+			return
+		}
+
 		if n.Responded == 0 && n.SelectedActionID == "" {
 			n.Show()
 		}

notifier/tray.go

@@ -57,7 +57,10 @@ func onReady() {
 				log.Warningf("failed to start app: %s", err)
 				return
 			}
-			cmd.Process.Release()
+			err = cmd.Process.Release()
+			if err != nil {
+				log.Warningf("failed to release app process: %s", err)
+			}
 		})
 		systray.AddSeparator()
 	}