Increase FD_SETSIZE from its default of 64 on Cygwin #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some documentation (the explanation in this PR could be a comment in the code). |
|
Ok, no problem--I figured you'd ask. Just wanted to make sure you were OK with the general approach first. |
|
Thanks--how soon do you think we can get this update into Sage? It's not super important but nice to have for running the tests. |
5 minutes if needs be :-) |
|
Well, okay. It's not an emergency, but thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same problem that tso-22839 is addressing, but applied to Cysignals (specifically the pselect module). It's necessarily to manually bump up
FD_SETSIZEto something reasonable, and ISTM the easiest way to do that consistently, especially with Cython, is to pass it at build time.This came up in Sage when running
./sage -twith a large number of processes.