Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: some care for Hadamard matrices #27013

Closed
fchapoton opened this issue Jan 4, 2019 · 11 comments
Closed

py3: some care for Hadamard matrices #27013

fchapoton opened this issue Jan 4, 2019 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: b806b2e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27013
@fchapoton fchapoton added this to the sage-8.6 milestone Jan 4, 2019
@fchapoton
Copy link
Contributor Author

New commits:

3c18778py3: some care for Hadamard matrices

@fchapoton
Copy link
Contributor Author

Commit: 3c18778

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27013

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2019

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2019

Reviewer: Travis Scrimshaw

@embray
Copy link
Contributor

embray commented Jan 10, 2019

comment:4

This could avoid a superfluous list(...) by just using a list comprehension instead.

@embray embray modified the milestones: sage-8.6, sage-8.7 Jan 10, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2019

Changed commit from 3c18778 to b806b2e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

b806b2ereviewer nitpick

@embray
Copy link
Contributor

embray commented Jan 10, 2019

comment:7

Thank you, that looks much better IMO.

@vbraun
Copy link
Member

vbraun commented Jan 22, 2019

Changed branch from u/chapoton/27013 to b806b2e

@vbraun vbraun closed this as completed in c128368 Jan 22, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @fchapoton