Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At the end of configure, indicate which optional/experimental packages are configured to be installed #29363

Closed
mkoeppe opened this issue Mar 18, 2020 · 9 comments
Closed

At the end of configure, indicate which optional/experimental packages are configured to be installed #29363

mkoeppe opened this issue Mar 18, 2020 · 9 comments
Labels
c: build: configure p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 18, 2020

This is a follow-up on #28788, which implemented the current version of the "Build status for each package" displayed at the end of configure.

For an optional package that is not installed already, it displays a message like the following:

e_antic-0.1.5: does not support check for system package; optional, use "./configure --enable-e_antic" to install

In this ticket, we change the message if the package has been configured to be installed.

To this end, we introduce the variable SAGE_ENABLE_<SPKG> for each optional/experimental SPKG. We also AC_SUBST these variables for future use by the build system.

CC: @dimpase @jhpalmieri @orlitzky @slel

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 22d7ae4

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29363
@mkoeppe mkoeppe added this to the sage-9.1 milestone Mar 18, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 9, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 29, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2020

Branch: u/mkoeppe/at_the_end_of_configure__indicate_which_optional_experimental_packages_are_configured_to_be_installed

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2020

Commit: 22d7ae4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2020

New commits:

22d7ae4m4/sage_spkg_*.m4: At the end of configure, indicate which optional/experimental packages are configured to be installed

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.2 Sep 13, 2020
@dimpase
Copy link
Member

dimpase commented Sep 14, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Sep 14, 2020

comment:7

OK, does what's described.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 14, 2020

comment:8

Thanks!

@vbraun
Copy link
Member

vbraun commented Sep 18, 2020

Changed branch from u/mkoeppe/at_the_end_of_configure__indicate_which_optional_experimental_packages_are_configured_to_be_installed to 22d7ae4

@vbraun vbraun closed this as completed in fc5bfc7 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe