Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict between lazy attribute and abstract method tester #29694

Closed
mwageringel opened this issue May 16, 2020 · 8 comments
Closed

conflict between lazy attribute and abstract method tester #29694

mwageringel opened this issue May 16, 2020 · 8 comments

Comments

@mwageringel
Copy link

This ticket fixes a test suite failure that occurs when a lazy attribute raises a NotImplementedError.

sage: class NotAbstract(SageObject):
....:     @lazy_attribute
....:     def bla(self):
....:         raise NotImplementedError("not implemented")
sage: NotAbstract()._test_not_implemented_methods()
...
AssertionError: Not implemented method: bla

The method _test_not_implemented_methods should only fail when an AbstractMethod is not implemented.

CC: @kwankyu

Component: misc

Author: Markus Wageringel

Branch/Commit: 68cee52

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/29694

@mwageringel mwageringel added this to the sage-9.2 milestone May 16, 2020
@mwageringel
Copy link
Author

Commit: 68cee52

@mwageringel
Copy link
Author

New commits:

68cee5229694: fix conflict between lazy attribute/abstract method

@mwageringel
Copy link
Author

Author: Markus Wageringel

@mwageringel
Copy link
Author

Branch: u/gh-mwageringel/29694

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 16, 2020

comment:3

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 16, 2020

Reviewer: Kwankyu Lee

@mwageringel
Copy link
Author

comment:5

Thank you.

@vbraun
Copy link
Member

vbraun commented Jul 28, 2020

Changed branch from u/gh-mwageringel/29694 to 68cee52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants