Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old thebe package #33529

Closed
mkoeppe opened this issue Mar 19, 2022 · 10 comments
Closed

Remove old thebe package #33529

mkoeppe opened this issue Mar 19, 2022 · 10 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 19, 2022

(split out from #24593)

Follow-up on #33309, which disabled use of the old thebe in our HTML documentation.

CC: @kwankyu @nthiery

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 9621c97

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/33529
@mkoeppe mkoeppe added this to the sage-9.6 milestone Mar 19, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 19, 2022

Branch: u/mkoeppe/remove_old_thebe_package

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 19, 2022

New commits:

e881abcbuild/pkgs/thebe: Remove
9621c97build/pkgs/sagemath_doc_html/dependencies: Remove thebe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 19, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 19, 2022

Commit: 9621c97

@nthiery
Copy link
Contributor

nthiery commented Mar 20, 2022

comment:3

+1; let it be now that jupyter-sphinx will provide a robust
Thebe implementation.

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 22, 2022

comment:4

This merge-conflict with #33507. Maybe could be resolved here.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 22, 2022

comment:5

Done

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 22, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 22, 2022

comment:6

It is safe to remove Thebe from sage.

@vbraun
Copy link
Member

vbraun commented Apr 2, 2022

Changed branch from u/mkoeppe/remove_old_thebe_package to 9621c97

@vbraun vbraun closed this as completed in b9cdb7c Apr 2, 2022
@videlec videlec mentioned this issue Jan 29, 2023
Open
13 tasks
@kwankyu kwankyu mentioned this issue Jan 29, 2023
Closed
@vbraun vbraun mentioned this issue Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
4 participants
@nthiery @vbraun @kwankyu @mkoeppe