Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python3 to 3.10.8 #34271

Closed
mkoeppe opened this issue Aug 3, 2022 · 18 comments
Closed

Update python3 to 3.10.8 #34271

mkoeppe opened this issue Aug 3, 2022 · 18 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 3, 2022

https://docs.python.org/3.10/whatsnew/changelog.html#changelog

However, 3.10.7 introduced a bizarre change in the name of security (https://docs.python.org/3.10/whatsnew/changelog.html#security) that limits the number of digits of integer that Python accepts when converting from str. https://docs.python.org/3.10/library/stdtypes.html#int-max-str-digits This was fixed in #34506.

Depends on #34506

CC: @antonio-rojas @dimpase

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 9bf562f

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34271

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 3, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

Branch: u/mkoeppe/update_python3_to_3_10_6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

New commits:

e8e162cbuild/pkgs/python3: Update to 3.10.6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 3, 2022

Commit: e8e162c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 8, 2022

Changed commit from e8e162c to f943313

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 8, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a9eaae5tox.ini, build/bin/write-dockerfile.sh: Add 'tox -e docker-...-incremental'
b9bfbf9tox.ini: Add comment
4c0d7f5tox.ini: Use FROM_DOCKER_REPOSITORY
a07874dbuild/bin/write-dockerfile.sh: In incremental build, keep logs
ae269d1tox.ini (docker-incremental): Do not include '-incremental' in the Docker image name
b354a38tox.ini, .github/workflows/docker.yml: Reimplement -incremental via SKIP_SYSTEM_PACKAGES
5decaddbuild/bin/write-dockerfile.sh: Do not use persistent env var PACKAGES (except on nix)
f109a5cMerge #34228
fc94f90Merge tag '9.7.rc1' into t/34271/update_python3_to_3_10_6
f943313build/pkgs/python3: Update to 3.10.7

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 8, 2022
@mkoeppe mkoeppe changed the title Update python3 to 3.10.6 Update python3 to 3.10.7 Sep 8, 2022
@antonio-rojas
Copy link
Contributor

comment:5

The aforementioned change in 3.10.7 breaks a couple of tests:

**********************************************************************
File "/usr/lib/python3.10/site-packages/sage/interfaces/octave.py", line 171, in sage.interfaces.octave.Octave
Failed example:
    t = '"{}"'.format(10^10000)
Exception raised:
    Traceback (most recent call last):
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.octave.Octave[0]>", line 1, in <module>
        t = '"{}"'.format(Integer(10)**Integer(10000))
      File "sage/rings/integer.pyx", line 1129, in sage.rings.integer.Integer.__format__ (build/cythonized/sage/rings/integer.c:8955)
        return int(self).__format__(*args,**kwargs)
    ValueError: Exceeds the limit (4300) for integer string conversion
**********************************************************************
File "/usr/lib/python3.10/site-packages/sage/rings/integer.pyx", line 6748, in sage.rings.integer.Integer.inverse_mod
Failed example:
    c = a.inverse_mod(a*a)   # long time
Expected:
    Traceback (most recent call last):
    ...
    ZeroDivisionError: inverse of Mod(..., ...) does not exist
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib/python3.10/site-packages/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.rings.integer.Integer.inverse_mod[5]>", line 1, in <module>
        c = a.inverse_mod(a*a)   # long time
      File "sage/rings/integer.pyx", line 6774, in sage.rings.integer.Integer.inverse_mod (build/cythonized/sage/rings/integer.c:42059)
        raise ZeroDivisionError(f"inverse of Mod({self}, {m}) does not exist")
      File "sage/rings/integer.pyx", line 1129, in sage.rings.integer.Integer.__format__ (build/cythonized/sage/rings/integer.c:8955)
        return int(self).__format__(*args,**kwargs)
    ValueError: Exceeds the limit (4300) for integer string conversion
**********************************************************************

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 8, 2022

Dependencies: #34506

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 8, 2022

comment:7

I've opened the ticket #34506 because Sage will also be affected when system python 3.10.7 is in use

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 13, 2022

comment:9

3.10.8 is out

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 13, 2022

Changed commit from f943313 to 9bf562f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 13, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1269c5abuild/pkgs/python3: Update to 3.10.6
ddcd2cabuild/pkgs/python3: Update to 3.10.7
9bf562fbuild/pkgs/python3: Update to 3.10.8

@mkoeppe mkoeppe changed the title Update python3 to 3.10.7 Update python3 to 3.10.8 Oct 13, 2022
@kwankyu
Copy link
Collaborator

kwankyu commented Oct 13, 2022

comment:13

Simple upgrade. LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 13, 2022

Reviewer: Kwankyu Lee

@kwankyu

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 13, 2022

comment:14

Thank you!

@vbraun
Copy link
Member

vbraun commented Oct 17, 2022

Changed branch from u/mkoeppe/update_python3_to_3_10_6 to 9bf562f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants