-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade igraph to 0.9.10 #34491
Comments
New commits:
|
Author: Matthias Koeppe |
Commit: |
comment:3
Installs without problems on macOS (Intel), haven't tested anything else. |
comment:4
install ok on fedora 35. I'm currently upgrading homebrew (and in graph). Will try soon with brew version of igraph. |
comment:5
I'm on macOS 12.5.1 and after a
In a fresh shell, I did: I'm now trying this ticket and so did Configure says:
But it tries to download sources anyway, and of course fails to do so.
What's wrong here ? |
comment:6
it should be
|
comment:7
just a mistake of copy paste in the comment, but it's what I did. The question is more: why is it trying to download from upstream when I have homebrew install if |
comment:8
Replying to David Coudert:
What's in |
comment:9
in case, run |
comment:10
Replying to Dima Pasechnik:
All lines of
I did However, I don't understand why it's not using the homebrew install |
comment:11
|
Reviewer: David Coudert |
comment:12
I didn't know that. So on macOS, it's working well when we compile the source. So for me this patch is good to go. |
comment:13
Upstream cautions that igraph 0.10 is not compatible - https://sagemath.zulipchat.com/#narrow/stream/271086-feedback/topic/hello/near/297322407 So we should either set a version upper bound in igraph's spkg-configure, or to the upgrade of both igraph, python-igraph to 0.10 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:15
Unlikely that this would still make it into Sage 9.7, but here we go |
comment:16
Follow-up: #34498 Update igraph, python_igraph to 0.10 |
This comment has been minimized.
This comment has been minimized.
comment:18
LGTM. |
Changed branch from u/mkoeppe/upgrade_igraph_to_0_9_10 to |
Suggested in https://sagemath.zulipchat.com/#narrow/stream/271086-feedback/topic/hello/near/297088245
Marked "critical" because we set a necessary upper bound for the version of igraph in spkg-configure.m4
CC: @dcoudert @dimpase
Component: packages: optional
Author: Matthias Koeppe
Branch/Commit:
d51e167
Reviewer: David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/34491
The text was updated successfully, but these errors were encountered: