Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boost-cropped to 1.82.0 #34748

Open
dimpase opened this issue Nov 14, 2022 · 8 comments
Open

update boost-cropped to 1.82.0 #34748

dimpase opened this issue Nov 14, 2022 · 8 comments

Comments

@dimpase
Copy link
Member

dimpase commented Nov 14, 2022

our boost is 5+ years old, and it apparently is a problem, cf #34726 (solved); #35801 (open)

Component: packages: standard

Author: Dima Pasechnik

Branch/Commit: u/dimpase/packages/boost_1_80_0 @ b7c7fde

Issue created by migration from https://trac.sagemath.org/ticket/34748

@dimpase dimpase added this to the sage-9.8 milestone Nov 14, 2022
@dimpase
Copy link
Member Author

dimpase commented Nov 14, 2022

New commits:

b7c7fdeupdate boost_cropped to 1.80.0

@dimpase
Copy link
Member Author

dimpase commented Nov 14, 2022

Commit: b7c7fde

@dimpase
Copy link
Member Author

dimpase commented Nov 14, 2022

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Nov 14, 2022

Branch: u/dimpase/packages/boost_1_80_0

@dimpase
Copy link
Member Author

dimpase commented Nov 14, 2022

comment:2

Should we bump the minimal system-wide version of boost to something like 1.74 (like in stable Debian)?

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Dec 31, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 12, 2023

Outdated - 1.81 is out

@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
@mkoeppe mkoeppe changed the title update boost-cropped to 1.80.0 update boost-cropped to 1.82.0 Jun 22, 2023
@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 22, 2023

Let's switch to using https://github.com/scipy/boost-headers-only instead of using our own spkg-src script.

Happening in #35807

@jhpalmieri
Copy link
Member

Is this a good place to put boost-related issues? On OS X, I deleted the homebrew boost package. Sage thought it detected a usable version somewhere — here is a snippet from config.log:

## -------------------------------------------------------------- ##
## Checking whether SageMath should install SPKG boost_cropped... ##
## -------------------------------------------------------------- ##
configure:17331: checking for boostlib >= 1.66.0 (106600)
configure:17363: g++ -std=gnu++11 -std=gnu++11 -c   -I/opt/local/include conftest.cpp >&5
configure:17363: $? = 0
configure:17366: result: yes
configure:17532: will use system package and not install SPKG boost_cropped

But the build failed with brial:

../../libbrial/include/polybori/common/traits.h:26:10: fatal error: 'boost/preprocessor/cat.hpp' file not found
#include <boost/preprocessor/cat.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Doing brew install boost fixed this, but of course this was not suggested by ./configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants