Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intersection of ideals in a number field #6457

Closed
loefflerd mannequin opened this issue Jul 2, 2009 · 10 comments
Closed

Intersection of ideals in a number field #6457

loefflerd mannequin opened this issue Jul 2, 2009 · 10 comments
Assignees
@williamstein
Labels
c: number theory p: minor / 4 t: bug
Milestone
sage-4.1.1

Comments

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 2, 2009

This is not difficult but for some reason it wasn't implemented before. Here it is.

Component: number theory

Keywords: ideals

Author: David Loeffler

Reviewer: Nick Alexander

Merged: sage-4.1.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6457
@loefflerd loefflerd mannequin added this to the sage-4.1.1 milestone Jul 2, 2009
@loefflerd loefflerd mannequin assigned williamstein Jul 2, 2009
@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jul 2, 2009

patch against 4.1.alpha2

@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jul 2, 2009

comment:1

Attachment: trac_6457-ideal_intersection.patch.gz

@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jul 2, 2009

Changed keywords from ideal to ideals

@loefflerd loefflerd mannequin added the s: needs review label Jul 2, 2009
@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jul 14, 2009

Author: Nick Alexander

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jul 14, 2009

comment:2

These doctests don't convince me that the the results are correct, but I don't see a one line way to assert that, so: positive review!

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jul 14, 2009

Reviewer: David Loeffler

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 18, 2009

Merged: sage-4.1.1.alpha0

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 18, 2009

Changed reviewer from David Loeffler to Nick Alexander

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 18, 2009

Changed author from Nick Alexander to David Loeffler

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 18, 2009

comment:3

I assume David is the author of trac_6457-ideal_intersection.patch, since Nick reviewed this ticket. David, the patch trac_6457-ideal_intersection.patch doesn't contain your username. So I'm committing it in your name.

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Jul 18, 2009
@sagetrac-fwclarke sagetrac-fwclarke mannequin mentioned this issue Jan 19, 2010
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: number theory p: minor / 4 t: bug
Projects
None yet
Milestone
sage-4.1.1
Development

No branches or pull requests
1 participant
@williamstein