Update to bliss 0.77

[antonio-rojas]

Comes with a cmake-based build system now (albeit with no install target), so the autotoolization patches shouldn't be needed. Not sure about the other patches included in the fork, but in case any of them is still needed we might consider to keep them here rather than in an outside fork for transparency.

Needs changes in sagelib for the new canonical_form and find_automorphisms API.

Fixes: #33010

[antonio-rojas]

@kiwifb I think I've pulled all commits from trac including your cmake changes, please double check.

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (363cdb9) 88.61%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35344      +/-   ##
===========================================
- Coverage    88.62%   88.61%   -0.02%     
===========================================
  Files         2148     2148              
  Lines       398855   398855              
===========================================
- Hits        353480   353440      -40     
- Misses       45375    45415      +40     

see 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kiwifb]

Looks great and the bots are happy apart from the linter. I will try to figure what it complains about.

[kiwifb]

Good to go

[dimpase]

all good

[dimpase]

it's a part of the updated interface, needed due to API changes. It's a C++ header file, it's cleaner this way, than trying to do the same in Cython (which in case of C++ is rather arcane). We can move it to a subdirectory in sage/graphs.

…

On Sat, 24 Jun 2023, 08:43 David Coudert, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ On src/sage/graphs/bliss_find_automorphisms.h <#35344 (comment)>: Is this file necessary ? can't this be done in a file named bliss.pxd ? or should we create a subdirectory bliss to store this file and everything related to bliss to have something clean ? — Reply to this email directly, view it on GitHub <#35344 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJXYHG6WQKNRJTB7WISW3LXM2LA7ANCNFSM6AAAAAAWG63ARQ> . You are receiving this because you commented.Message ID: ***@***.***>

[dcoudert]

A subdirectory as done for cliquer might be better.

[dimpase]

A subdirectory as done for cliquer might be better.

this is now antonio-rojas#1 - to be merged by @antonio-rojas

[mkoeppe]

I had to make this change to get it compile on macOS (with Xcode)

diff --git a/src/sage/graphs/bliss.pyx b/src/sage/graphs/bliss.pyx
index 373b99f4d5..d8c50f220e 100644
--- a/src/sage/graphs/bliss.pyx
+++ b/src/sage/graphs/bliss.pyx
@@ -1,4 +1,5 @@
 # distutils: language = c++
+# distutils: extra_compile_args = -std=c++11
 # distutils: libraries = bliss
 # sage_setup: distribution = sagemath-bliss
 

[dimpase]

I had to make this change to get it compile on macOS (with Xcode)

diff --git a/src/sage/graphs/bliss.pyx b/src/sage/graphs/bliss.pyx
index 373b99f4d5..d8c50f220e 100644
--- a/src/sage/graphs/bliss.pyx
+++ b/src/sage/graphs/bliss.pyx
@@ -1,4 +1,5 @@
 # distutils: language = c++
+# distutils: extra_compile_args = -std=c++11
 # distutils: libraries = bliss
 # sage_setup: distribution = sagemath-bliss
 

OK, added.

[github-actions]

Documentation preview for this PR (built with commit 3ee7616; changes) is ready! 🎉