Bliss spkg config #35830
Merged
Bliss spkg config #35830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not 100% something more is needed, as bliss is optional |
mkoeppe
reviewed
Jun 27, 2023
mkoeppe
reviewed
Jun 27, 2023
|
@kiwifb was that your cmake patch? We shouldn't start depending on a build system patch until upstream knows about it. Nightmares of palp. |
|
Yes, it my patch. And it is from so long ago that I do not remember if upstream has been notified. Basically upstream did not provide an install target. I fixed that. |
|
I've mailed this patch to upstream. No response. |
|
ping? |
dimpase
force-pushed
the
bliss_spkg_config
branch
from
3b77ad1
to
8623d9a
Compare
|
tests pass (few failures on Conda, irrelevant to this ticket) |
mkoeppe
force-pushed
the
bliss_spkg_config
branch
from
8623d9a
to
75c1cca
Compare
|
Documentation preview for this PR (built with commit 75c1cca; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 4, 2023
Provide spkg-config for bliss, with minimal version 0.77. Depends on sagemath#35344, where Sage's bliss is bumped to 0.77 with the necessary API changes. Fixes sagemath#35829 URL: sagemath#35830 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide spkg-config for bliss, with minimal version 0.77.
Depends on #35344, where Sage's bliss is bumped to 0.77
with the necessary API changes.
Fixes #35829