Old sagenb changes since the flask fork

[jasongrout]

See http://trac.sagemath.org/sage_trac/ticket/11080#comment:49, where jdemeyer lists tickets that we should check to make sure they are merged in the new sagenb. In particular, please double-check that following tickets really have been merged in the new sagenb:

#10052 fixed at 88a1cea
#10860 gh-8
#11106 fixed at 01d4caf
#11121 gh-7
#11732 gh-17
#11343 underlying issue fixed at gh-11
#10620 gh-9
#10642 gh-10

In pull requests for these, reference this issue (i.e., this is a meta-issue). When the last ticket above is merged, close this issue.

[kini]

Mark Manashirov just submitted two patches to the old notebook, at #9785 and #12232. Both of them involve the Simple Server API which is currently marked as broken in sagenb/simple/twist.py. Should I include them on this ticket or make another one for reviving the Simple Server API?

[kini]

#10052 seems to have been done in 88a1cea.

[kini]

#11106 was done by 01d4caf.

[jasongrout]

Oh, wait, this ticket was more than just gh-7. Reopening...

[jasongrout]

@kini: can you update us on this? (Sorry it's so confusing having three different bug trackers).

[kini]

I posted on trac #11732 asking for the original author or reviewer to try to rebase the patch, but if nothing happens I guess I will try to do it myself. But feel free to do it yourself, of course - no need to wait for me. Anyway you know the notebook code a lot better than I.

As for gh-11, should we just put it in? kcrisman doesn't want to install the flask notebook to test, but I can take your word for it that it fixes the problem completely.

[jasongrout]

I guess we have a lot of changes that haven't been individually reviewed in the past few months. I'm okay with putting the tinymce fix, but it would be good if you or someone could at least look at the change and double-check to see if it makes sense, or if I was just crazy. It would be great if someone could set up a server and let kcrisman check it. Unfortunately, sagenb.org is running very low on disk space again, so I can't do it there.

[jasongrout]

I most likely won't have time to do #11732 in the next week.

[kini]

Well, it looks OK to me. And I don't see how it could be a nonsensical change if it did fix the problem, after all! I'll merge it.

[jasongrout]

The point being that: is there some problem with the regex now that I completely missed? I think the change is safe enough.

[kini]

Right, I did read the diff and the change looks safe to me too.

[jasongrout]

11732 was merged in gh-17