Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

Move flask_version directory #204

Merged
merged 5 commits into from
Aug 21, 2014
Merged

Conversation

ppurka
Copy link
Member

@ppurka ppurka commented Apr 8, 2014

This is for moving the flask_version directory to inside sagenb. It should fix the first point of #203

@fchapoton
Copy link
Contributor

There may be something to do in sagenb/messages.pot:

grep "../flask" *
message.pot:#: flask_version/worksheet.py:27 ../flask_version/worksheet.py:36
message.pot:#: flask_version/worksheet.py:75 ../flask_version/worksheet.py:951

@ppurka
Copy link
Member Author

ppurka commented Aug 7, 2014

Thanks. Made the necessary changes.

@kcrisman
Copy link
Member

Okay, this seems to work fine and certainly I can't think of a reason it wouldn't, other than not quite understanding subtleties of links. That is, I assume this immediately "takes effect" - I don't have to do any python setup develop or whatever, just the linking of this version of sagenb in the egg, right?

I will definitely make it a priority to review any documentation fixes you make on this end regarding this, and hopefully we can make the most minimal possible changes to the doc on the Sage end as well, if necessary. https://github.com/sagemath/sagenb/blob/master/HACKING.rst is pretty sadly out of date as of now...

kcrisman added a commit that referenced this pull request Aug 21, 2014
@kcrisman kcrisman merged commit 96c5cc6 into sagemath:master Aug 21, 2014
@kcrisman
Copy link
Member

Okay, now I will just wait pining for doc changes to review :-)

@ppurka
Copy link
Member Author

ppurka commented Aug 23, 2014

Thanks. I am traveling for the next week. Will look into the flurry of
activity in sage and sagenb after I return!
On Aug 21, 2014 10:36 PM, "kcrisman" notifications@github.com wrote:

Okay, now I will just wait pining for doc changes to review :-)


Reply to this email directly or view it on GitHub
#204 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants