This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Fix Missing version numbers (issue #228) #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Umm, probably there are a few other reported issues that are more important right now! ( #169 comes to mind.) Though of course long-term that would be great. Anyway, here I think that the "ugly" fix does fit in with the way this is handled in the other places it's done, so it's fine for now. However, note that the help page also doesn't have it. I think this would be changeable at sagenb/flask_version/base.py near |
|
Done. |
kcrisman
added a commit
that referenced
this pull request
Sep 17, 2014
Missing version numbers (Fixes #228)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is very ugly, but is the only thing I can do in order to keep the changes minimal. The template rendering mechanism is somehow heterogeneous. Time for a deep code cleanup and refactor?