Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mirrors.yaml #139

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Update mirrors.yaml #139

merged 1 commit into from
Jul 26, 2018

Conversation

slel
Copy link
Member

@slel slel commented Jul 26, 2018

Fix links to two mirrors: Rediris, Spain; and Stellenbosch, South Africa.
Set inactive mirrors to "active: false".

Fix links to two mirrors: Rediris, Spain; and Stellenbosch, South Africa.
Set inactive mirrors to "active: false".
url: ftp://ftp.sun.ac.za/pub/mirrors/www.sagemath.org/
- active: true
url: http://ftp.sun.ac.za/ftp/pub/mirrors/www.sagemath.org/
- active: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it deactivated? http://ftp.sun.ac.za/ftp/pub/mirrors/www.sagemath.org/ loads fine for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, next one, I see ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a bit confusing in the diff view, but the structure is

- active: xx  # true/false --- whether mirror is active
  cat: xx     # a/af/aus/e/na/sa for Asia/Africa/Oceania/Europe/NAm/SAm
  country: xx           # country code
  flag: xx              # country code for the flag
  name: xx, yy, zz      # name (eg Uni Something), city, country
  priority: 1000        # priority: 1 master, 10 secondary master, ...
  url: http://example.com/mirror/sage/  # url --- must end with /

and the diff view often has the name and url of one mirror
combined with the active status of the next mirror.

@haraldschilly
Copy link
Member

well, there is no need to deactivate any of them because they're probed by a script anyways. still merging it, that just makes the script run faster.

@haraldschilly haraldschilly merged commit 8095b75 into sagemath:master Jul 26, 2018
@haraldschilly
Copy link
Member

and your changes broke the build itself. i'm fixing this, and also exposing the error message for travis-ci. it's a missing slash:

bash scripts/mirror_manager_wrapper.sh
Traceback (most recent call last):
  File "mirror_manager.py", line 137, in <module>
    MIRRORS = [Mirror(**m) for m in yaml.load(codecs.open(MIRROR_YAML, "r", "utf8"))]
  File "mirror_manager.py", line 113, in __init__
    assert url.endswith("/")
AssertionError
makefile:20: recipe for target 'scripts/mirror_list' failed

haraldschilly added a commit that referenced this pull request Jul 26, 2018
@slel slel deleted the patch-4 branch July 26, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants