Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc minor issues with flyout panels #6737

Closed
williamstein opened this issue May 23, 2023 · 7 comments
Closed

misc minor issues with flyout panels #6737

williamstein opened this issue May 23, 2023 · 7 comments

Comments

@williamstein
Copy link
Contributor

-- The recent log and file search are both just a simple case sensitive substring search but should be identical to the actual log search, e.g., if you search "foo bar" it is an and search for the terms foo and bar. We have generic search code in util for search that is used everywhere in cocalc and obviously should be used here for consistency. It even supports regexp automatically.

image
  • Missing cursor and keyboard navigation for log and files.
@williamstein
Copy link
Contributor Author

There are soooo many little tiny issues. But I"m only noticing them since the overall idea of this is great.
Here's another which is a VERY serious bug.

  1. Click the New flyout panel.
  2. Type a.txt to make a file ending in txt (instead of an ipynb file), and you see this:
image 3. Click the blue button to make the file and you get "a.txt.txt". That's a bug.

Next it says "Click the type button twice". I do not see any other buttons or type buttons. Upon thinking hard about this and clicking around randomly, I think maybe "the type button" means the "filename extension", which is a dropdown menu. It's very hard to tell it is even clickable, but it is. Clicking it twice just opens and closes it. Maybe the type button existed in some iteration of this, and got deleted?


Anyway, as far as I can tell, it's completely impossible to just make a file "a.txt". I did try clicking on the huge extension dropdown, reading dozens of things to finally find the correct version of txt in that long menu (nobody is every going to do this), finally clicking on it, and literally nothing happens. The extension doesn't even change. So that's another bug at the end of a painful and bad UX.

@williamstein
Copy link
Contributor Author

If you open a task list then open the flyout panel, the keyboard shortcuts still go to the task list. In particular, you can't type searches, filenames, etc.

There's quite a bit of subtle stuff going on in enabling and disabling global keyboard handlers. I think most things work, but task list + side panel isn't working.

WORKAROUND/HINT: open and focus the side chat, which will disable the tasks keyboard handler, and then you can type in the search box.

@williamstein williamstein changed the title misc minor issues without flyout panels misc minor issues with flyout panels Jun 9, 2023
@williamstein
Copy link
Contributor Author

Another bug.

  1. Open the find flyout panel and search for something
  2. Try to copy text from one of the results without opening the corresponding file, and it isn't possible.

I do this all the time with the normal Find page and it works well there.

@williamstein
Copy link
Contributor Author

williamstein commented Jun 9, 2023

Still unfixed:

  • tasks keyboard shortcut issue, e.g., with file explorer side panel
  • copying text from find results

The other issues ABOVE in this thread are fixed.

A missing feature is the cursor isn't implemented for the Log, though it is implemented nicely for the Explorer :-).

@williamstein
Copy link
Contributor Author

williamstein commented Jun 12, 2023

  • The Find flyout panel now has a large checkbox group that can't be scrolled away. That's sort of good, since it was confusing before when it did scroll away. However, it also greatly reduces the space to actually look at results. On a small screen you might only get 20% of the screen for search results...

@williamstein
Copy link
Contributor Author

williamstein commented Jun 15, 2023

Everything above is done (for me). However, these are some minor issues I'm seeing now:

  • @haraldschilly The text in the log doesn't properly wrap -- it's cutoff due to the width being not equal to that of the container or something. I hit this constantly when searching for a file I recently edited. See how the filename is being cut off:
image
  • The find options uses switches in the side panel and checkboxes in the main page. That's inconsistent, and because you have to explicitly submit the result, checkboxes are the correct choice.

@williamstein
Copy link
Contributor Author

Closed, since everything has been fixed here or copied to #6802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant