Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Add a "Preferred colour scheme" combobox to Settings. JB#58394 #1007

Merged
merged 1 commit into from
Nov 26, 2022
Merged

[browser] Add a "Preferred colour scheme" combobox to Settings. JB#58394 #1007

merged 1 commit into from
Nov 26, 2022

Conversation

llewelld
Copy link
Member

Adds a "Preferred colour scheme" combobox to the Settings page for controlling the WebEngineSettings.colorScheme property.

This was referenced Nov 23, 2022
Merged
Merged
@llewelld
Copy link
Member Author

Part of a quiver of four PRs:

  1. [sailfishos][gecko] Add support for prefers-color-scheme. JB#58394 gecko-dev#149
  2. [qtmozembed] Add colorMode property for prefers-color-scheme support. JB#58394 qtmozembed#47
  3. [browser] Add a "Preferred colour scheme" combobox to Settings. JB#58394 #1007
  4. [webview-docs] Add docs for doNotTrack and colorScheme. JB#58394 sailfish-components-webview#161

@llewelld llewelld mentioned this pull request Nov 23, 2022
Merged
@llewelld llewelld requested a review from rainemak November 23, 2022 07:29
rainemak
rainemak approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test on device but looks reasonable.

@llewelld
[browser] Add a "Preferred colour scheme" combobox to Settings. JB#58394
ae95aa1 
Adds a "Preferred colour scheme" combobox to the Settings page for
controlling the WebEngineSettings.colorScheme property.
@llewelld llewelld merged commit 4f0d4ca into sailfishos:next Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainemak rainemak rainemak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llewelld @rainemak