Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components-webview] Fix click handling after selection. Contributes to JB#56311 #152

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

mkenttala
Copy link
Contributor

No description provided.

@mkenttala
Copy link
Contributor Author

Modified to use separate rects for the start and end handles. Also made the mousearea smaller so it's a lot easier to hit the quote button in sailfish forum. Because of the animation in the handles I wasn't able to use mousearea directly so the rects are calculated whenever animations stop.

Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor remarks added.

import/controls/TextSelectionHandle.qml Outdated Show resolved Hide resolved
import/controls/TextSelectionHandle.qml Outdated Show resolved Hide resolved
import/controls/TextSelectionHandle.qml Outdated Show resolved Hide resolved
import/controls/TextSelectionHandle.qml Outdated Show resolved Hide resolved
Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants