swap open with opn to remove critical error on audit

sailshq · Jun 7, 2018 · a7e0bd0 · mikermcneil · Jun 26, 2018 · a7e0bd0
1 parent 75c3685
commit a7e0bd0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/lib/open-browser.js b/lib/open-browser.js
@@ -23,7 +23,7 @@ module.exports = {
   fn: function (inputs, exits){
 
     // Import `open` and `openBrowserAndNavigateToUrl`.
-    var openBrowserAndNavigateToUrl = require('open');
+    var openBrowserAndNavigateToUrl = require('opn');
 
     // Attempt to open the given URL in a browser window.
     openBrowserAndNavigateToUrl(inputs.url);

diff --git a/package.json b/package.json
@@ -16,9 +16,10 @@
   "license": "MIT",
   "dependencies": {
     "@sailshq/lodash": "^3.10.2",
+    "ajv": "^6.5.0",
     "machine": "^15.0.0-23",
     "machinepack-json": "^2.0.0",
-    "open": "0.0.5"
+    "opn": "^5.3.0"
   },
   "devDependencies": {
     "async": "2.0.1",

diff --git a/test/escape-as-command-line-opt.json5 → test/escape-as-command-line-opt.json b/test/escape-as-command-line-opt.json5 → test/escape-as-command-line-opt.json
@@ -2,7 +2,6 @@
   "machine": "escape-as-command-line-opt",
   "expectations": [
 
-    // Number
     {
       "using": {
         "value": 4
@@ -11,7 +10,6 @@
       "returns": "4"
     },
 
-    // Boolean
     {
       "using": {
         "value": true
@@ -20,7 +18,6 @@
       "returns": "true"
     },
 
-    // Basic string
     {
       "using": {
         "value": "hello"
@@ -29,7 +26,6 @@
       "returns": "hello"
     },
 
-    // String with nasty single quotes everywhere
     {
       "using": {
         "value": "st'''uff w/ nasty quotes''' everywhere'"
@@ -38,7 +34,6 @@
       "returns": "st'\\'''\\'''\\''uff w/ nasty quotes'\\'''\\'''\\'' everywhere'\\''"
     },
 
-    // Tricky string that happens to be a JSON string
     {
       "using": {
         "value": "{ \"some encoded dict\" : \"st'''uff w/ nasty quotes''' everywhere'\"}"
@@ -47,15 +42,14 @@
       "returns": "{\"some encoded dict\":\"st'\\'''\\'''\\''uff w/ nasty quotes'\\'''\\'''\\'' everywhere'\\''\"}"
     },
 
-    // A dictionary
     {
       "using": {
         "value": {
           "some nested dict" : {
             "foo": ["st'''uff w/ nasty quotes''' everywhere'"]
           },
           "some nested number": 32,
-          "some nested string" : "more st'''uff w/ nasty quotes''' everywhere'",
+          "some nested string" : "more st'''uff w/ nasty quotes''' everywhere'"
         }
       },
       "outcome": "success",