Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data files for themes and plugins using setuptools package-data #503

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

dvzrv
Copy link
Contributor

@dvzrv dvzrv commented Oct 27, 2023

Use setuptools' package-data [1] to unconditionally add all files
below sigal's themes/ dir and all data files below the
plugins/encrypt/static/ dir to a wheel.
This works without any SCM integration and without MANIFEST.in.

Fixes #500

[1] https://setuptools.pypa.io/en/latest/userguide/datafiles.html#package-data

Use setuptools' `package-data` [1] to unconditionally add all files
below sigal's `themes/` dir and all data files below the
`plugins/encrypt/static/` dir to a wheel.
This works without any SCM integration and without `MANIFEST.in`.

Fixes saimn#500

[1] https://setuptools.pypa.io/en/latest/userguide/datafiles.html#package-data

Signed-off-by: David Runge <dave@sleepmap.de>
@dvzrv dvzrv changed the title Unconditionally add all files below the themes dir to wheel Add data files for themes and plugins using setuptools package-data Oct 27, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #503 (ebedd9f) into main (6bd9cd3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files          25       25           
  Lines        2062     2062           
=======================================
  Hits         1829     1829           
  Misses        233      233           

@saimn
Copy link
Owner

saimn commented Nov 8, 2023

Thanks for the PR!
With include-package-data = true this shouldn't be needed, at least from what I understand from https://setuptools.pypa.io/en/latest/userguide/datafiles.html#subdirectory-for-data-files, but package data has always been a confusing thing with setuptools so fine by me :)

@saimn saimn merged commit 6abcf10 into saimn:main Nov 8, 2023
7 of 8 checks passed
@saimn saimn added this to the 2.5 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.4: Themes are not installed, leading to failing tests
2 participants