Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #478 の不備修正 #479

Merged
merged 2 commits into from
Sep 24, 2018
Merged

PR #478 の不備修正 #479

merged 2 commits into from
Sep 24, 2018

Conversation

m-tmatma
Copy link
Member

PR #478 の不備修正
(UTF-8 BOM 付きのファイルが失敗してしまいます)

@m-tmatma m-tmatma added IMPORTANT 早急に解消すべきもの CI appveyor など CI 関連 【ChangeLog除外】 🐛bug🦋 ■バグ修正(Something isn't working) labels Sep 24, 2018
@m-tmatma
Copy link
Member Author

テスト不足で申し訳ないです。

berryzplus
berryzplus approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utf-8とutf-8-sigが違うもの、という空気は読みました。
予想される意味の違いで不都合はなさそうなので通してしまいます。

@berryzplus berryzplus merged commit 7ff251f into sakura-editor:master Sep 24, 2018
@m-tmatma m-tmatma deleted the feature/fix-PR478 branch September 25, 2018 05:21
@m-tmatma m-tmatma added this to the next release milestone Sep 25, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@berryzplus
Merge pull request sakura-editor#479 from m-tmatma/feature/fix-PR478
499b16d 
PR sakura-editor#478 の不備修正
@beru beru mentioned this pull request Aug 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
🐛bug🦋 ■バグ修正(Something isn't working) CI appveyor など CI 関連 【ChangeLog除外】 IMPORTANT 早急に解消すべきもの
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@m-tmatma @berryzplus