Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

バージョンを 2.4.0 の開発版に上げる #713

Merged
merged 3 commits into from
Dec 25, 2018
Merged

バージョンを 2.4.0 の開発版に上げる #713

merged 3 commits into from
Dec 25, 2018

Conversation

m-tmatma
Copy link
Member

バージョンを 2.4.0 の開発版に上げる

#685 (comment)

@m-tmatma m-tmatma added this to the next release milestone Dec 19, 2018
@m-tmatma m-tmatma mentioned this pull request Dec 19, 2018
Closed
berryzplus
berryzplus reviewed Dec 20, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目的への同意を表明します。
整合性見れてないんでコメントだけ。

@KENCHjp KENCHjp added management 運営に関する話題 【ChangeLog除外】 CI appveyor など CI 関連 【ChangeLog除外】 labels Dec 20, 2018
@m-tmatma
Copy link
Member Author

APPVEYOR_DEV_VERSION をタグが指定されているときには定義しないように
してましたが、常に定義するようにしました。

  • git 環境外でビルドするとき
  • 正式リリースではないけどタグを付けたいとき

に意図せず dev が取れるので、release ブランチ上で手動で無効化したほうがいいからです。

@m-tmatma
Copy link
Member Author

レビュープリーズ

berryzplus
berryzplus approved these changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。
横長になってたのを\の行継続で分かち書きにしてるので変更量が多く見えました
横長よりは改行してどんなパラメータを使ってるか見えたほうがいいと思います。

@m-tmatma m-tmatma merged commit c551dbe into sakura-editor:master Dec 25, 2018
m-tmatma added a commit to m-tmatma/sakura that referenced this pull request Dec 30, 2018
@m-tmatma
ヘルプのバージョンを 2.4.0 に update (sakura-editor#713 に追従)
6e9a855
@m-tmatma m-tmatma mentioned this pull request Dec 30, 2018
Merged
m-tmatma added a commit that referenced this pull request Dec 31, 2018
@m-tmatma
Merge pull request #739 from m-tmatma/feature/help-version-2-4-0
03641d6 
ヘルプのバージョンを 2.4.0 に update (#713 に追従)
@m-tmatma m-tmatma mentioned this pull request Apr 14, 2019
Closed
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@m-tmatma
Merge pull request sakura-editor#713 from m-tmatma/feature/bump-to-2_…
676ec1e 
…4.0-dev

バージョンを 2.4.0 の開発版に上げる
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@m-tmatma
ヘルプのバージョンを 2.4.0 に update (sakura-editor#713 に追従)
2d9906a
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@m-tmatma
Merge pull request sakura-editor#739 from m-tmatma/feature/help-versi…
5caeae9 
…on-2-4-0

ヘルプのバージョンを 2.4.0 に update (sakura-editor#713 に追従)
@m-tmatma m-tmatma deleted the feature/bump-to-2_4.0-dev branch July 5, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
CI appveyor など CI 関連 【ChangeLog除外】 management 運営に関する話題 【ChangeLog除外】
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@m-tmatma @berryzplus @KENCHjp