Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length of the text as default features for text fields #187

Closed

Conversation

tmpsrcrepo
Copy link
Contributor

@tmpsrcrepo tmpsrcrepo commented Nov 28, 2018

Related issues
Add text length as a new feature

Describe the proposed solution
Created TextLenTransformer and TextMapLenEstimator and modify the vectorizer to include a new toggle feature

Describe alternatives you've considered

@tmpsrcrepo tmpsrcrepo changed the title Xl/text len transformer Add length of the text as default features for text fields Nov 28, 2018
@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #187 into master will decrease coverage by 0.15%.
The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   86.31%   86.15%   -0.16%     
==========================================
  Files         307      301       -6     
  Lines        9971     9819     -152     
  Branches      336      345       +9     
==========================================
- Hits         8606     8460     -146     
+ Misses       1365     1359       -6
Impacted Files Coverage Δ
.../com/salesforce/op/features/TransientFeature.scala 64.28% <0%> (-6.31%) ⬇️
...e/op/stages/impl/feature/TextMapLenEstimator.scala 100% <100%> (ø)
...sforce/op/utils/spark/OpVectorColumnMetadata.scala 77.77% <100%> (+2.22%) ⬆️
...p/stages/impl/feature/SmartTextMapVectorizer.scala 100% <100%> (ø) ⬆️
...ce/op/stages/impl/feature/TextLenTransformer.scala 100% <100%> (ø)
...e/op/stages/impl/feature/SmartTextVectorizer.scala 97.72% <100%> (+0.32%) ⬆️
...c/main/scala/com/salesforce/op/ModelInsights.scala 92.56% <100%> (-0.07%) ⬇️
...n/scala/com/salesforce/op/dsl/RichMapFeature.scala 79.1% <30%> (-2.44%) ⬇️
.../scala/com/salesforce/op/dsl/RichTextFeature.scala 89.23% <71.42%> (-1.1%) ⬇️
...sforce/op/stages/impl/feature/Transmogrifier.scala 95.49% <78.26%> (-1.26%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e839a7...619ba28. Read the comment docs.

@tovbinm
Copy link
Collaborator

tovbinm commented Feb 7, 2019

This PR was split into #190, #195 and merged in.

@tovbinm tovbinm closed this Feb 7, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants