feat(best-frontend): Fix ploty axis (#69)

salesforce · Feb 6, 2018 · 38d5092 · 38d5092
1 parent 013b196
commit 38d5092
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/best-frontend/src/modules/one/page-project/normalize-benchmarks.js b/packages/best-frontend/src/modules/one/page-project/normalize-benchmarks.js
@@ -1,7 +1,8 @@
 function collectBenchmarkData(commitBenchmarks, commit, stat, collector = {}, name = '') {
     if (commitBenchmarks.benchmarks) {
         return commitBenchmarks.benchmarks.reduce((l, b) => {
-            return collectBenchmarkData(b, commit, stat, l, name + (commitBenchmarks.benchmarkName || ''));
+            const postName = commitBenchmarks.benchmarkName || commitBenchmarks.name || '';
+            return collectBenchmarkData(b, commit, stat, l, name ? `${name}:${postName}` : postName);
         }, collector);
     }
 

diff --git a/packages/best-frontend/src/modules/one/page-project/plots.js b/packages/best-frontend/src/modules/one/page-project/plots.js
@@ -28,7 +28,8 @@ function buildPlottyLayout({ title }) {
 
 function buildPlottyTrace({ commits, values, metric }, opts) {
     return {
-        x: commits,
+        // Using a zero-width char (https://en.wikipedia.org/wiki/Zero-width_space) to force plotty to render labels
+        x: commits.map(c => '#\u200B' + c),
         y: values,
         mode: 'lines+markers',
         name: metric,