Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(best-frontend): Fix ploty axis #69

Merged
merged 1 commit into from
Feb 6, 2018
Merged

feat(best-frontend): Fix ploty axis #69

merged 1 commit into from
Feb 6, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Feb 6, 2018

Details

Fix axis plotting

Does this PR introduce a breaking change?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:

Reminders ( please delete this section before submitting )


The PR fulfills these requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Title

LWC PR title follows conventional commit format and is automatically validated by our CI.

ex:
commit-type(optional scope): commit description. ( NOTE: space between column and the message )

Types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test, proposal.
Scope: The scope should be the name of the npm package affected (engine, compiler, wire-service, etc.)

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 013b196 | Target commit: 94dd673

benchmark base(013b196) target(94dd673) trend
object_keys.benchmark:stringify_parse 0.42 (± 0.04 ms) 0.47 (± 0.04 ms) 👎
object_keys.benchmark:deep_merge 0.47 (± 0.05 ms) 0.52 (± 0.05 ms) 👎
simple-item.benchmark:create_and_render 61.92 (± 1.99 ms) 65.24 (± 1.99 ms) 👎

@diervo diervo merged commit 38d5092 into master Feb 6, 2018
@diervo diervo deleted the dval/plotlyFix branch February 6, 2018 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant