-
Notifications
You must be signed in to change notification settings - Fork 434
Add Welcome Mat Component #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is just an initial commit, and these are the shortcomings as of now-
The code is also pretty rough right now, I will be working on this in the coming days :) |
I will try to look at this next week. |
@aswinshenoy please add ids to every component that accepts them in your examples. Also add the welcome-mat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aswinshenoy looking good so far! I'll take another look once you've addressed these issues and updated your browser tests
@kevinparkerson I made the suggested changes and wrote browser tests. I missed writing a test for checking whether clicking on Tile takes to the Please Review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it over, it's good to go! Thanks for all your good work on this @aswinshenoy!!!
Fixes #1876
Additional description
Adds Welcome Mat component following the SLDS pattern
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).REVIEWER checklist (do not remove)
components/component-docs.json
tests.Required only if there are markup / UX changes
last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.