Skip to content

Add Welcome Mat Component #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jun 27, 2019
Merged

Conversation

aswinshenoy
Copy link
Contributor

@aswinshenoy aswinshenoy commented Apr 22, 2019

Fixes #1876

Additional description

Adds Welcome Mat component following the SLDS pattern

welcomemat


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@aswinshenoy
Copy link
Contributor Author

This is just an initial commit, and these are the shortcomings as of now-

  • DSR Modal doesn't support slds-modal_small, so the welcome mat cannot be correctly fit like in SLDS. I have not worked on closing and opening of modal, as I am not sure whether the component will be manually called under a or be always under a modal.
  • Trailblazer badges

The code is also pretty rough right now, I will be working on this in the coming days :)

@interactivellama
Copy link
Contributor

I will try to look at this next week.

@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 6, 2019 03:09 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 12, 2019 01:20 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 14, 2019 21:34 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 14, 2019 21:53 Inactive
@interactivellama interactivellama had a problem deploying to design-system-react-co-pr-1934 June 14, 2019 23:18 Failure
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 14, 2019 23:35 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 17, 2019 01:25 Inactive
@kevinparkerson
Copy link
Contributor

kevinparkerson commented Jun 20, 2019

@aswinshenoy please add ids to every component that accepts them in your examples.

Also add the welcome-mat docs.json contents to the components array in the LDSR's package.json file

@kevinparkerson kevinparkerson self-requested a review June 20, 2019 20:09
Copy link
Contributor

@kevinparkerson kevinparkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aswinshenoy looking good so far! I'll take another look once you've addressed these issues and updated your browser tests

@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 21, 2019 05:00 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 23, 2019 07:44 Inactive
@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 23, 2019 13:31 Inactive
@aswinshenoy
Copy link
Contributor Author

aswinshenoy commented Jun 24, 2019

@kevinparkerson I made the suggested changes and wrote browser tests. I missed writing a test for checking whether clicking on Tile takes to the href link, would that be necessary? That is perhaps the only interactivity test I guess we will have, the others I have written are purely markup checks (something snapshot testing would have done).

Please Review :)

@interactivellama interactivellama temporarily deployed to design-system-react-co-pr-1934 June 25, 2019 03:09 Inactive
@kevinparkerson kevinparkerson self-requested a review June 26, 2019 23:35
kevinparkerson
kevinparkerson previously approved these changes Jun 26, 2019
Copy link
Contributor

@kevinparkerson kevinparkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it over, it's good to go! Thanks for all your good work on this @aswinshenoy!!!

@kevinparkerson kevinparkerson temporarily deployed to design-system-react-co-pr-1934 June 27, 2019 00:04 Inactive
@kevinparkerson kevinparkerson temporarily deployed to design-system-react-co-pr-1934 June 27, 2019 02:37 Inactive
@kevinparkerson kevinparkerson merged commit 046ac8f into salesforce:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Welcome Mat Component
3 participants