Lint rule unsupported date filter #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifeng-li-at-salesforce
requested review from
khawkins,
sfdctaka,
maliroteh-sf and
ben-zhang-at-salesforce
as code owners
sfdctaka
reviewed
May 28, 2024
sfdctaka
reviewed
May 28, 2024
| export const NO_FISCAL_DATE_FILTER_SUPPORTED_RULE_ID = | ||
| 'offline-graphql-no-fiscal-date-filter-supported'; | ||
|
|
||
| type NodeWithParent = { |
There was a problem hiding this comment.
we can remove this late in the 3 hard limit rules pr once types.ts in pulled in.
There was a problem hiding this comment.
Or the other way around? Do you really need to use the whole type.ts or can you make define your own type?
ben-zhang-at-salesforce
approved these changes
May 28, 2024
sfdctaka
reviewed
May 28, 2024
haifeng-li-at-salesforce
force-pushed
the
lintRuleUnsupportedDateFilter
branch
from
283120e to
298de32
Compare
ben-zhang-at-salesforce
approved these changes
May 29, 2024
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-15792664
per Feature Limitations of Offline Graphql, graphql local eval doesn't support fiscal date related query.
These 6 fiscal date related literal are not supported
THIS_FISCAL_YEAR,
LAST_FISCAL_YEAR,
NEXT_FISCAL_YEAR
THIS_FISCAL_QUATER,
LAST_FISAL_QUATER,
NEXT_FISCAL_QUATER
These 6 fiscal date range are not supported
last_n_fiscal_quarters
next_n_fiscal_quarters
last_n_fiscal_years
next_n_fiscal_years
n_fiscal_quarter_ago
n_fiscal_years_ago
The rule detects and reports warning if above date filter shows up in graphql query.