fix(babel-plugin-component): skip unnecessary registerDecorators (BREAKING CHANGE) #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nolanlawson
changed the base branch from
prerelease-v4.0.0
to
milestone-v4.0.0
…register-decorators-redux
divmain
reviewed
Aug 21, 2023
divmain
approved these changes
Aug 21, 2023
| import { api } from "lwc"; | ||
| import MyCoolMixin from './mixin.js' | ||
|
|
||
| const foo = class extends MyCoolMixin { |
There was a problem hiding this comment.
Do you only fail when it doesn't extend anything, since it couldn't possibly be extending LightningElement indirectly?
There was a problem hiding this comment.
Exactly. extends is a sniff for "might be a LightningElement."
| // Any class exposing a field *must* extend either LightningElement or some other superclass. | ||
| // Even in the case of superclasses and mixins that expose fields, those must extend something as well. | ||
| // So we can skip classes without a superclass to avoid adding unnecessary registerDecorators calls. | ||
| // However, we only do this in later API versions to avoid a breaking change. |
There was a problem hiding this comment.
Helpful comment, thank you.
| @@ -10,15 +10,20 @@ import { isNumber } from './language'; | |||
| export const enum APIVersion { | |||
| V58_244_SUMMER_23 = 58, | |||
| V59_246_WINTER_24 = 59, | |||
| V60_248_SPRING_24 = 60, | |||
There was a problem hiding this comment.
Minor nit: Since we're going to be seeing more of these, it'd be nice to have them introduced in a separate PR to keep commit history clean & PRs more readable.
There was a problem hiding this comment.
Fair enough. I avoided it since it was like 3 lines though, and since I knew I would have to deal with conflicts anyway once I merged everything all together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #2701. New version of #2741
In API version 60+,
registerDecoratorsis no longer called for classes that do not extend a superclass (and thus cannot possibly beLightningElementclasses).Does this pull request introduce a breaking change?
Previously, the following would not be a syntax error:
In v60+, this will be a syntax error. The decorators
@track,@wire, and@apican only be used onLightningElementclasses. In the above case,MyCustomClassdoes notextendanother class, so it cannot possibly be aLightningElementclass. The fix is to remove the unnecessary@track,@wire, and@apidecorators.Does this pull request introduce an observable change?
See above.
GUS work item
W-10736098